-
Notifications
You must be signed in to change notification settings - Fork 5k
JIT: Avoid unnecessary GTF_GLOB_REFs #84349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Avoid unnecessary GTF_GLOB_REFs #84349
Conversation
* Avoid setting GTF_GLOB_REF on GT_FIELD_ADDR nodes * Avoid setting GTF_GLOB_REF on GT_FIELD nodes off of implicit byrefs. This is ok now since implicit byref morphing indiscriminately sets GTF_GLOB_REF for these. These changes are necessary to avoid address exposure in the two user benchmarks in dotnet#83388. Fix dotnet#74563
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue Details
These changes are necessary to avoid address exposure in the two user benchmarks in #83388:
Both of these cases are fixed with this PR. Fix #74563
|
/azp run Fuzzlyn, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
Azure Pipelines successfully started running 3 pipeline(s). |
The hardware intrinsics test failure should be fixed by #84352. The Fuzzlyn failure is preexisting. cc @dotnet/jit-contrib PTAL @SingleAccretion @EgorBo |
Almost forgot - this also fixes #856. |
gtClone
does not handleFIELD_ADDR
, and making it handle this needs some more work.These changes are necessary to avoid address exposure in the two user benchmarks in #83388:
Fix #74563
Fix #856