-
Notifications
You must be signed in to change notification settings - Fork 5k
Update NativeAOT build integration targets to include ioslike platforms #82086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kotlarmilos
merged 21 commits into
dotnet:main
from
kotlarmilos:feature/nativeaot-targets-ios
Feb 20, 2023
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7bfbbce
Adjust Native AOT build integration targets to include ios and iossim…
kotlarmilos e242cf0
Merge branch 'dotnet:main' into feature/nativeaot-targets-ios
kotlarmilos 28412d7
Resolve conflicts
kotlarmilos 9c7e5d8
Fix TargetOS for iossimulator in build integration targets
kotlarmilos e1c255d
Revert conditions for linux targets
kotlarmilos 947a514
Add _IsApplePlatform property and update Native.Unix.targets
kotlarmilos 1acfce5
Add tvos, tvossimulator, and maccatalyst to _IsApplePlatform
kotlarmilos 7da9fba
Merge branch 'main' into feature/nativeaot-targets-ios
kotlarmilos 9dd5067
Remove _IsApplePlatform from Native.Unix.targets
kotlarmilos f4a4964
Merge branch 'feature/nativeaot-targets-ios' of github.com:kotlarmilo…
kotlarmilos 8363dc5
Add a condition to OSIdentifier to respect the order of the checks
kotlarmilos efb53b5
Update src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILComp…
kotlarmilos 25df2fc
Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Nativ…
kotlarmilos 6e67656
Update src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILComp…
kotlarmilos 7012650
Update src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILComp…
kotlarmilos a3035e5
Exclude <NativeFramework Include=GSS /> for tvOS[simulator]
kotlarmilos ee8832a
Exclude System.Globalization.Native and System.Security.Cryptography.…
kotlarmilos 675b5a0
Fix tvOS condition for GSS
kotlarmilos 3283372
Exclude System.Globalization.Native and System.Security.Cryptography.…
kotlarmilos 407edf3
Add condition to TargetOS property
kotlarmilos f2b51ec
Update tvOS condition
kotlarmilos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,12 +15,12 @@ The .NET Foundation licenses this file to you under the MIT license. | |
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<PropertyGroup> | ||
<CppCompilerAndLinkerAlternative /> | ||
<CppCompilerAndLinkerAlternative Condition="'$(CppCompilerAndLinker)' == '' and '$(TargetOS)' != 'osx'">gcc</CppCompilerAndLinkerAlternative> | ||
<CppCompilerAndLinkerAlternative Condition="'$(CppCompilerAndLinker)' == '' and '$(_IsApplePlatform)' != 'true'">gcc</CppCompilerAndLinkerAlternative> | ||
<CppCompilerAndLinker Condition="'$(CppCompilerAndLinker)' == ''">clang</CppCompilerAndLinker> | ||
<CppLinker>$(CppCompilerAndLinker)</CppLinker> | ||
<CppLibCreator>ar</CppLibCreator> | ||
<DsymUtilOptions Condition="'$(TargetOS)' == 'osx'">--flat</DsymUtilOptions> | ||
<_SymbolPrefix Condition="'$(TargetOS)' == 'osx'">_</_SymbolPrefix> | ||
<DsymUtilOptions Condition="'$(_IsApplePlatform)' == 'true'">--flat</DsymUtilOptions> | ||
<_SymbolPrefix Condition="'$(_IsApplePlatform)' == 'true'">_</_SymbolPrefix> | ||
<UseLLVMLinker Condition="'$(UseLLVMLinker)' == '' and '$(TargetOS)' == 'freebsd'">true</UseLLVMLinker> | ||
</PropertyGroup> | ||
|
||
|
@@ -35,16 +35,16 @@ The .NET Foundation licenses this file to you under the MIT license. | |
|
||
<CrossCompileArch /> | ||
<CrossCompileArch Condition="$(CrossCompileRid.EndsWith('-x64'))">x86_64</CrossCompileArch> | ||
<CrossCompileArch Condition="$(CrossCompileRid.EndsWith('-arm64')) and '$(TargetOS)' != 'osx'">aarch64</CrossCompileArch> | ||
<CrossCompileArch Condition="$(CrossCompileRid.EndsWith('-arm64')) and '$(TargetOS)' == 'osx'">arm64</CrossCompileArch> | ||
<CrossCompileArch Condition="$(CrossCompileRid.EndsWith('-arm64')) and '$(_IsApplePlatform)' != 'true'">aarch64</CrossCompileArch> | ||
<CrossCompileArch Condition="$(CrossCompileRid.EndsWith('-arm64')) and '$(_IsApplePlatform)' == 'true'">arm64</CrossCompileArch> | ||
|
||
<TargetTriple /> | ||
<TargetTriple Condition="'$(CrossCompileArch)' != ''">$(CrossCompileArch)-linux-gnu</TargetTriple> | ||
<TargetTriple Condition="'$(CrossCompileArch)' != '' and ($(CrossCompileRid.StartsWith('linux-musl')) or $(CrossCompileRid.StartsWith('alpine')))">$(CrossCompileArch)-alpine-linux-musl</TargetTriple> | ||
<TargetTriple Condition="'$(CrossCompileArch)' != '' and ($(CrossCompileRid.StartsWith('freebsd')))">$(CrossCompileArch)-unknown-freebsd12</TargetTriple> | ||
|
||
<IlcRPath Condition="'$(IlcRPath)' == '' and '$(TargetOS)' != 'osx'">$ORIGIN</IlcRPath> | ||
<IlcRPath Condition="'$(IlcRPath)' == '' and '$(TargetOS)' == 'osx'">@executable_path</IlcRPath> | ||
<IlcRPath Condition="'$(IlcRPath)' == '' and '$(_IsApplePlatform)' != 'true'">$ORIGIN</IlcRPath> | ||
<IlcRPath Condition="'$(IlcRPath)' == '' and '$(_IsApplePlatform)' == 'true'">@executable_path</IlcRPath> | ||
|
||
<EventPipeName>libeventpipe-disabled</EventPipeName> | ||
<EventPipeName Condition="'$(EnableNativeEventPipe)' == 'true'">libeventpipe-enabled</EventPipeName> | ||
|
@@ -63,11 +63,13 @@ The .NET Foundation licenses this file to you under the MIT license. | |
|
||
<ItemGroup> | ||
<NetCoreAppNativeLibrary Include="System.Native" /> | ||
<NetCoreAppNativeLibrary Include="System.Globalization.Native" Condition="'$(StaticICULinking)' != 'true'" /> | ||
<!-- FIXME: The library is currently not available for iOS-like platforms --> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we have an issue we could link to? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just created and linked: #82389 |
||
<NetCoreAppNativeLibrary Include="System.Globalization.Native" Condition="'$(StaticICULinking)' != 'true' and '$(_IsiOSLikePlatform)' != 'true'" /> | ||
<NetCoreAppNativeLibrary Include="System.IO.Compression.Native" /> | ||
<NetCoreAppNativeLibrary Include="System.Net.Security.Native" /> | ||
<NetCoreAppNativeLibrary Include="System.Security.Cryptography.Native.Apple" Condition="'$(TargetOS)' == 'osx'" /> | ||
<NetCoreAppNativeLibrary Include="System.Security.Cryptography.Native.OpenSsl" Condition="'$(StaticOpenSslLinking)' != 'true'" /> | ||
<NetCoreAppNativeLibrary Include="System.Security.Cryptography.Native.Apple" Condition="'$(_IsApplePlatform)' == 'true'" /> | ||
<!-- Not compliant for iOS-like platforms --> | ||
<NetCoreAppNativeLibrary Include="System.Security.Cryptography.Native.OpenSsl" Condition="'$(StaticOpenSslLinking)' != 'true' and '$(_IsiOSLikePlatform)' != 'true'" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
|
@@ -100,52 +102,53 @@ The .NET Foundation licenses this file to you under the MIT license. | |
<StaticSslLibs Include="-Wl,-Bdynamic" Condition="'$(StaticExecutable)' != 'true'" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup Condition="'$(TargetOS)' == 'osx'"> | ||
<ItemGroup Condition="'$(_IsApplePlatform)' == 'true'"> | ||
akoeplinger marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<NativeFramework Include="CoreFoundation" /> | ||
<NativeFramework Include="CryptoKit" /> | ||
<NativeFramework Include="Foundation" /> | ||
<NativeFramework Include="Security" /> | ||
<NativeFramework Include="GSS" /> | ||
<!-- The library builds don't reference the GSS API on tvOS builds. --> | ||
<NativeFramework Condition="!$(TargetOS.StartsWith('tvos'))" Include="GSS" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<LinkerArg Include="-fuse-ld=lld" Condition="'$(UseLLVMLinker)' == 'true'" /> | ||
<LinkerArg Include="@(NativeLibrary)" /> | ||
<LinkerArg Include="--sysroot=$(SysRoot)" Condition="'$(SysRoot)' != ''" /> | ||
<LinkerArg Include="--target=$(TargetTriple)" Condition="'$(TargetOS)' != 'osx' and '$(TargetTriple)' != ''" /> | ||
<LinkerArg Include="-arch $(CrossCompileArch)" Condition="'$(TargetOS)' == 'osx' and '$(CrossCompileArch)' != ''" /> | ||
<LinkerArg Include="--target=$(TargetTriple)" Condition="'$(_IsApplePlatform)' != 'true' and '$(TargetTriple)' != ''" /> | ||
<LinkerArg Include="-arch $(CrossCompileArch)" Condition="'$(_IsApplePlatform)' == 'true' and '$(CrossCompileArch)' != ''" /> | ||
<LinkerArg Include="-g" Condition="$(NativeDebugSymbols) == 'true'" /> | ||
<LinkerArg Include="-Wl,--strip-debug" Condition="$(NativeDebugSymbols) != 'true' and '$(TargetOS)' != 'osx'" /> | ||
<LinkerArg Include="-Wl,--strip-debug" Condition="$(NativeDebugSymbols) != 'true' and '$(_IsApplePlatform)' != 'true'" /> | ||
<LinkerArg Include="-Wl,-rpath,'$(IlcRPath)'" Condition="'$(StaticExecutable)' != 'true'" /> | ||
<LinkerArg Include="-Wl,--build-id=sha1" Condition="'$(TargetOS)' != 'osx'" /> | ||
<LinkerArg Include="-Wl,--as-needed" Condition="'$(TargetOS)' != 'osx'" /> | ||
<LinkerArg Include="-Wl,-e0x0" Condition="'$(NativeLib)' == 'Shared' and '$(TargetOS)' != 'osx'" /> | ||
<LinkerArg Include="-pthread" Condition="'$(TargetOS)' != 'osx'" /> | ||
<LinkerArg Include="-Wl,--build-id=sha1" Condition="'$(_IsApplePlatform)' != 'true'" /> | ||
<LinkerArg Include="-Wl,--as-needed" Condition="'$(_IsApplePlatform)' != 'true'" /> | ||
<LinkerArg Include="-Wl,-e0x0" Condition="'$(NativeLib)' == 'Shared' and '$(_IsApplePlatform)' != 'true'" /> | ||
<LinkerArg Include="-pthread" Condition="'$(_IsApplePlatform)' != 'true'" /> | ||
<LinkerArg Include="-lstdc++" Condition="'$(LinkStandardCPlusPlusLibrary)' == 'true'" /> | ||
<LinkerArg Include="-ldl" /> | ||
<LinkerArg Include="-lobjc" Condition="'$(TargetOS)' == 'osx'" /> | ||
<LinkerArg Include="-lswiftCore" Condition="'$(TargetOS)' == 'osx'" /> | ||
<LinkerArg Include="-lswiftFoundation" Condition="'$(TargetOS)' == 'osx'" /> | ||
<LinkerArg Include="-lobjc" Condition="'$(_IsApplePlatform)' == 'true'" /> | ||
<LinkerArg Include="-lswiftCore" Condition="'$(_IsApplePlatform)' == 'true'" /> | ||
<LinkerArg Include="-lswiftFoundation" Condition="'$(_IsApplePlatform)' == 'true'" /> | ||
<LinkerArg Include="-lz" /> | ||
<LinkerArg Include="-lrt" Condition="'$(TargetOS)' != 'osx'" /> | ||
<LinkerArg Include="-licucore" Condition="'$(TargetOS)' == 'osx'" /> | ||
<LinkerArg Include="-L/usr/lib/swift" Condition="'$(TargetOS)' == 'osx'" /> | ||
<LinkerArg Include="-lrt" Condition="'$(_IsApplePlatform)' != 'true'" /> | ||
<LinkerArg Include="-licucore" Condition="'$(_IsApplePlatform)' == 'true'" /> | ||
<LinkerArg Include="-L/usr/lib/swift" Condition="'$(_IsApplePlatform)' == 'true'" /> | ||
<LinkerArg Include="@(StaticNumaLibs)" Condition="'$(StaticNumaLinking)' == 'true'" /> | ||
<LinkerArg Include="@(StaticICULibs)" Condition="'$(StaticICULinking)' == 'true'" /> | ||
<LinkerArg Include="@(StaticSslLibs)" Condition="'$(StaticOpenSslLinking)' == 'true'" /> | ||
<LinkerArg Include="-lm" /> | ||
<LinkerArg Include="-static" Condition="'$(StaticExecutable)' == 'true' and '$(PositionIndependentExecutable)' == 'false'" /> | ||
<LinkerArg Include="-static-pie" Condition="'$(StaticExecutable)' == 'true' and '$(PositionIndependentExecutable)' != 'false'" /> | ||
<LinkerArg Include="-dynamiclib" Condition="'$(TargetOS)' == 'osx' and '$(NativeLib)' == 'Shared'" /> | ||
<LinkerArg Include="-shared" Condition="'$(TargetOS)' != 'osx' and '$(NativeLib)' == 'Shared'" /> | ||
<LinkerArg Include="-dynamiclib" Condition="'$(_IsApplePlatform)' == 'true' and '$(NativeLib)' == 'Shared'" /> | ||
<LinkerArg Include="-shared" Condition="'$(_IsApplePlatform)' != 'true' and '$(NativeLib)' == 'Shared'" /> | ||
<!-- binskim warning BA3001 PIE disabled on executable --> | ||
<LinkerArg Include="-pie -Wl,-pie" Condition="'$(TargetOS)' != 'osx' and '$(NativeLib)' == '' and '$(StaticExecutable)' != 'true' and '$(PositionIndependentExecutable)' != 'false'" /> | ||
<LinkerArg Include="-Wl,-no-pie" Condition="'$(TargetOS)' != 'osx' and '$(NativeLib)' == '' and '$(StaticExecutable)' != 'true' and '$(PositionIndependentExecutable)' == 'false'" /> | ||
<LinkerArg Include="-pie -Wl,-pie" Condition="'$(_IsApplePlatform)' != 'true' and '$(NativeLib)' == '' and '$(StaticExecutable)' != 'true' and '$(PositionIndependentExecutable)' != 'false'" /> | ||
<LinkerArg Include="-Wl,-no-pie" Condition="'$(_IsApplePlatform)' != 'true' and '$(NativeLib)' == '' and '$(StaticExecutable)' != 'true' and '$(PositionIndependentExecutable)' == 'false'" /> | ||
<!-- binskim warning BA3010 The GNU_RELRO segment is missing --> | ||
<LinkerArg Include="-Wl,-z,relro" Condition="'$(TargetOS)' != 'osx'" /> | ||
<LinkerArg Include="-Wl,-z,relro" Condition="'$(_IsApplePlatform)' != 'true'" /> | ||
<!-- binskim warning BA3011 The BIND_NOW flag is missing --> | ||
<LinkerArg Include="-Wl,-z,now" Condition="'$(TargetOS)' != 'osx'" /> | ||
<LinkerArg Include="-Wl,-u,$(_SymbolPrefix)NativeAOT_StaticInitialization" Condition="('$(UseLLVMLinker)' == 'true' or '$(TargetOS)' == 'osx' or '$(TargetOS)' == 'freebsd') and ('$(NativeLib)' == 'Shared' or '$(CustomNativeMain)' == 'true')" /> | ||
<LinkerArg Include="-Wl,-z,now" Condition="'$(_IsApplePlatform)' != 'true'" /> | ||
<LinkerArg Include="-Wl,-u,$(_SymbolPrefix)NativeAOT_StaticInitialization" Condition="('$(UseLLVMLinker)' == 'true' or '$(_IsApplePlatform)' == 'true' or '$(TargetOS)' == 'freebsd') and ('$(NativeLib)' == 'Shared' or '$(CustomNativeMain)' == 'true')" /> | ||
<LinkerArg Include="-Wl,--require-defined,NativeAOT_StaticInitialization" Condition="'$(UseLLVMLinker)' != 'true' and '$(TargetOS)' == 'linux' and ('$(NativeLib)' == 'Shared' or '$(CustomNativeMain)' == 'true')" /> | ||
<!-- this workaround can be deleted once the minimum supported glibc version | ||
(runtime's official build machine's glibc version) is at least 2.33 | ||
|
@@ -156,7 +159,7 @@ The .NET Foundation licenses this file to you under the MIT license. | |
<!-- FreeBSD's inotify is an installed package and not found in default libraries --> | ||
<LinkerArg Include="-L/usr/local/lib -linotify" Condition="'$(TargetOS)' == 'freebsd'" /> | ||
|
||
<LinkerArg Include="@(NativeFramework->'-framework %(Identity)')" Condition="'$(TargetOS)' == 'osx'" /> | ||
<LinkerArg Include="@(NativeFramework->'-framework %(Identity)')" Condition="'$(_IsApplePlatform)' == 'true'" /> | ||
</ItemGroup> | ||
|
||
<Exec Command="command -v "$(CppLinker)"" IgnoreExitCode="true" StandardOutputImportance="Low"> | ||
|
@@ -173,24 +176,24 @@ The .NET Foundation licenses this file to you under the MIT license. | |
<_WhereLinker>0</_WhereLinker> | ||
</PropertyGroup> | ||
|
||
<PropertyGroup Condition="'$(ObjCopyName)' == '' and '$(TargetOS)' != 'osx'"> | ||
<PropertyGroup Condition="'$(ObjCopyName)' == '' and '$(_IsApplePlatform)' != 'true'"> | ||
<ObjCopyName Condition="!$(CppCompilerAndLinker.Contains('clang'))">objcopy</ObjCopyName> | ||
<ObjCopyName Condition="$(CppCompilerAndLinker.Contains('clang'))">llvm-objcopy</ObjCopyName> | ||
<ObjCopyNameAlternative /> | ||
<ObjCopyNameAlternative Condition="$(CppCompilerAndLinker.Contains('clang'))">objcopy</ObjCopyNameAlternative> | ||
</PropertyGroup> | ||
|
||
<Error Condition="'$(_WhereLinker)' != '0' and '$(TargetOS)' == 'osx'" Text="Platform linker ('$(CppLinker)') not found in PATH. Try installing Xcode to resolve the problem." /> | ||
<Error Condition="'$(_WhereLinker)' != '0' and '$(_IsApplePlatform)' == 'true'" Text="Platform linker ('$(CppLinker)') not found in PATH. Try installing Xcode to resolve the problem." /> | ||
<Error Condition="'$(_WhereLinker)' != '0' and '$(CppCompilerAndLinkerAlternative)' != ''" | ||
Text="Platform linker ('$(CppLinker)' or '$(CppCompilerAndLinkerAlternative)') not found in PATH. Try installing appropriate package for $(CppLinker) or $(CppCompilerAndLinkerAlternative) to resolve the problem." /> | ||
<Error Condition="'$(_WhereLinker)' != '0' and '$(CppCompilerAndLinkerAlternative)' == '' and '$(TargetOS)' != 'osx'" | ||
<Error Condition="'$(_WhereLinker)' != '0' and '$(CppCompilerAndLinkerAlternative)' == '' and '$(_IsApplePlatform)' != 'true'" | ||
Text="Requested linker ('$(CppLinker)') not found in PATH." /> | ||
|
||
<Exec Command="command -v "$(ObjCopyName)"" IgnoreExitCode="true" StandardOutputImportance="Low" Condition="'$(TargetOS)' != 'osx' and '$(StripSymbols)' == 'true'"> | ||
<Exec Command="command -v "$(ObjCopyName)"" IgnoreExitCode="true" StandardOutputImportance="Low" Condition="'$(_IsApplePlatform)' != 'true' and '$(StripSymbols)' == 'true'"> | ||
<Output TaskParameter="ExitCode" PropertyName="_WhereSymbolStripper" /> | ||
</Exec> | ||
|
||
<Exec Command="command -v "$(ObjCopyNameAlternative)"" IgnoreExitCode="true" StandardOutputImportance="Low" Condition="'$(TargetOS)' != 'osx' and '$(ObjCopyNameAlternative)' != '' and '$(StripSymbols)' == 'true'"> | ||
<Exec Command="command -v "$(ObjCopyNameAlternative)"" IgnoreExitCode="true" StandardOutputImportance="Low" Condition="'$(_IsApplePlatform)' != 'true' and '$(ObjCopyNameAlternative)' != '' and '$(StripSymbols)' == 'true'"> | ||
<Output TaskParameter="ExitCode" PropertyName="_WhereSymbolStripperAlt" /> | ||
</Exec> | ||
|
||
|
@@ -201,16 +204,16 @@ The .NET Foundation licenses this file to you under the MIT license. | |
|
||
<Error Condition="'$(_WhereSymbolStripper)' != '0' and '$(StripSymbols)' == 'true' and '$(ObjCopyNameAlternative)' != ''" | ||
Text="Symbol stripping tool ('$(ObjCopyName)' or '$(ObjCopyNameAlternative)') not found in PATH. Try installing appropriate package for $(ObjCopyName) or $(ObjCopyNameAlternative) to resolve the problem." /> | ||
<Error Condition="'$(_WhereSymbolStripper)' != '0' and '$(StripSymbols)' == 'true' and '$(TargetOS)' != 'osx'" | ||
<Error Condition="'$(_WhereSymbolStripper)' != '0' and '$(StripSymbols)' == 'true' and '$(_IsApplePlatform)' != 'true'" | ||
Text="Symbol stripping tool ('$(ObjCopyName)') not found in PATH. Make sure '$(ObjCopyName)' is available in PATH" /> | ||
|
||
<Exec Command="command -v dsymutil && command -v strip" IgnoreExitCode="true" StandardOutputImportance="Low" Condition="'$(TargetOS)' == 'osx' and '$(StripSymbols)' == 'true'"> | ||
<Exec Command="command -v dsymutil && command -v strip" IgnoreExitCode="true" StandardOutputImportance="Low" Condition="'$(_IsApplePlatform)' == 'true' and '$(StripSymbols)' == 'true'"> | ||
<Output TaskParameter="ExitCode" PropertyName="_WhereSymbolStripper" /> | ||
</Exec> | ||
<Error Condition="'$(_WhereSymbolStripper)' != '0' and '$(StripSymbols)' == 'true' and '$(TargetOS)' != 'osx'" | ||
<Error Condition="'$(_WhereSymbolStripper)' != '0' and '$(StripSymbols)' == 'true' and '$(_IsApplePlatform)' != 'true'" | ||
Text="Symbol stripping tools ('dsymutil' and 'strip') not found in PATH. Make sure 'dsymutil' and 'strip' are available in PATH" /> | ||
|
||
<Exec Command="dsymutil --help" IgnoreExitCode="true" StandardOutputImportance="Low" Condition="'$(TargetOS)' == 'osx' and '$(StripSymbols)' == 'true'"> | ||
<Exec Command="dsymutil --help" IgnoreExitCode="true" StandardOutputImportance="Low" Condition="'$(_IsApplePlatform)' == 'true' and '$(StripSymbols)' == 'true'"> | ||
<Output TaskParameter="ExitCode" PropertyName="_DsymUtilOutput" /> | ||
</Exec> | ||
|
||
|
@@ -220,7 +223,7 @@ The .NET Foundation licenses this file to you under the MIT license. | |
<Exec Command="CC="$(CppLinker)" "$(IlcHostPackagePath)/native/src/libs/build-local.sh" "$(IlcHostPackagePath)/" "$(IntermediateOutputPath)" System.Security.Cryptography.Native" | ||
Condition="'$(StaticOpenSslLinking)' == 'true'" /> | ||
|
||
<PropertyGroup Condition="'$(TargetOS)' == 'osx' and '$(StripSymbols)' == 'true' and $(_DsymUtilOutput.Contains('--minimize'))"> | ||
<PropertyGroup Condition="'$(_IsApplePlatform)' == 'true' and '$(StripSymbols)' == 'true' and $(_DsymUtilOutput.Contains('--minimize'))"> | ||
<DsymUtilOptions>$(DsymUtilOptions) --minimize</DsymUtilOptions> | ||
</PropertyGroup> | ||
</Target> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.