-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Codespaces configuration based on development scenarios #74683
Conversation
Codespaces allows for monorepo support now. So we can have different pre-builds for different dev environments. Creating a "libraries" pre-build and a "wasm" pre-build devcontainer.
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsTaking advantage of the new "monorepo" projects feature in https://github.blog/changelog/2022-07-28-prebuilding-codespaces-is-now-supported-for-multi-repository-and-monorepo-projects/. This allows us to have different Codespaces pre-builds based on what kind of work you are doing. It also minimizes the down-time of pre-builds if one development scenario is broken (for example if the WASM prebuild is broken, libraries developers can still use the libraries pre-build). The duplication of the
This will require an admin to update the Codespaces in the Settings tab of the repo. I don't have access to do that.
|
I think that makes sense. You are installing a lot of common prereq packages that aren't going to change at a high frequency. |
This pull request has been automatically marked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WASM related change looks good to me! This is a great new feature. Now I could add the build for Mono desktop scenarios.
I have addressed all feedback and have manually tested this works in my fork. Once I merge, I'm going to need a repo admin to update the settings in order to get the Codespaces prebuilds working again. I plan on merging tomorrow unless I get more feedback. |
Developing in dotnet/runtime with a 2-core / 4GB ram machine doesn't work very well. Add a minimum of 4-core machine to the devcontainer spec. Fix dotnet#75680
Taking advantage of the new "monorepo" projects feature in https://github.blog/changelog/2022-07-28-prebuilding-codespaces-is-now-supported-for-multi-repository-and-monorepo-projects/.
This allows us to have different Codespaces pre-builds based on what kind of work you are doing. It also minimizes the down-time of pre-builds if one development scenario is broken (for example if the WASM prebuild is broken, libraries developers can still use the libraries pre-build).
The duplication of the
Dockerfile
is unfortunate. But I'm thinking if we can move these docker images to https://github.com/dotnet/dotnet-buildtools-prereqs-docker, we could:cc @MichaelSimons and @mthalman for thoughts on that.
This will require an admin to update the Codespaces in the Settings tab of the repo. I don't have access to do that.