Skip to content

Implement proper File System detection for Apple OSes #74493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Aug 24, 2022

fixes #69852
fixes #72786

it's a draft until CI ensures me that my assumptions were right

@ghost
Copy link

ghost commented Aug 24, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #69852

it's a draft until CI ensures me that my assumptions were right

Author: adamsitnik
Assignees: -
Labels:

area-System.IO

Milestone: -

@adamsitnik adamsitnik changed the title Don't use statfs on Apple systems, as for them it returns version-specific file system ids. Implement proper File System detection for Apple OSes Aug 24, 2022
@lambdageek
Copy link
Member

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adamsitnik adamsitnik marked this pull request as ready for review August 24, 2022 22:09
@adamsitnik adamsitnik requested a review from jozkee August 24, 2022 22:09
@adamsitnik
Copy link
Member Author

Perf LGTM:

BenchmarkDotNet=v0.13.1.1823-nightly, OS=macOS Monterey 12.3.1 (21E258) [Darwin 21.4.0]
Intel Core i7-5557U CPU 3.10GHz (Broadwell), 1 CPU, 4 logical and 2 physical cores
.NET SDK=7.0.100-rc.2.22424.12
  [Host]     : .NET 7.0.0 (7.0.22.42212), X64 RyuJIT
  Job-HMRXXT : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT
  Job-EKKFRV : .NET 8.0.0 (42.42.42.42424), X64 RyuJIT

LaunchCount=9
Method Toolchain fileSize options Mean Ratio
OpenClose /main/corerun 1024 None 14.37 us 1.00
OpenClose /pr/corerun 1024 None 14.31 us 1.00
OpenClose /main/corerun 1024 Asynchronous 14.17 us 1.00
OpenClose /pr/corerun 1024 Asynchronous 14.12 us 1.00

@adamsitnik
Copy link
Member Author

Failures are unrelated (#74170, helix deadletters for NativeAOT, timeouts)

@adamsitnik adamsitnik merged commit 5764faf into dotnet:main Aug 25, 2022
@adamsitnik
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2925323033

@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Copy/Create file on NFS share on macOS Implement proper File System detection for Apple OSes
3 participants