Skip to content

Fix GUID interop in distributed transactions and block ARM #74226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

roji
Copy link
Member

@roji roji commented Aug 19, 2022

Fixes #74170

@AaronRobinsonMSFT went through all the interop and added in to GUIDs where relevant.
@kunalspathak you indicated you're able to repro this, any chance you can give this PR a try to see if it fixes the issue?

@roji roji requested a review from AaronRobinsonMSFT August 19, 2022 08:26
@ghost ghost assigned roji Aug 19, 2022
@AaronRobinsonMSFT
Copy link
Member

/azp help

@azure-pipelines
Copy link

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@AaronRobinsonMSFT
Copy link
Member

/azp list

@azure-pipelines
Copy link

@AaronRobinsonMSFT
Copy link
Member

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kunalspathak
Copy link
Member

@roji - I can still see the failure happening.

@karelz karelz added this to the 8.0.0 milestone Aug 25, 2022
@roji roji force-pushed the DistributedTransactionsGuidInterop branch from ae78dcc to 545dca8 Compare August 25, 2022 12:28
@roji roji changed the base branch from main to release/7.0 August 25, 2022 12:33
@roji roji force-pushed the DistributedTransactionsGuidInterop branch from 545dca8 to a45922f Compare August 25, 2022 12:48
@roji roji changed the base branch from release/7.0 to main August 25, 2022 12:50
@roji roji force-pushed the DistributedTransactionsGuidInterop branch from a45922f to a64434f Compare August 25, 2022 12:50
@roji
Copy link
Member Author

roji commented Aug 25, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2926682783

@roji
Copy link
Member Author

roji commented Aug 25, 2022

Split the disabling of tests on arm64 out to #74572 on @karelz's advice, to make it easier to backport etc.

This PR still contains the GUID fix, and hopefully we can find the actual fix for the problem.

And fix GUID interop in distributed transactions

See dotnet#74170
@roji roji force-pushed the DistributedTransactionsGuidInterop branch from d0845d8 to fdfef13 Compare September 9, 2022 14:17
@roji roji changed the title Fix GUID interop in distributed transactions Fix GUID interop in distributed transactions and block ARM Sep 9, 2022
@roji roji merged commit 8f33fd5 into dotnet:main Sep 11, 2022
@roji roji deleted the DistributedTransactionsGuidInterop branch September 11, 2022 10:41
@ghost ghost locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distributed transactions: AccessViolationException on arm64
5 participants