Skip to content

Fix repro project for Release builds #73836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

MichalStrehovsky
Copy link
Member

No description provided.

@VSadov
Copy link
Member

VSadov commented Aug 12, 2022

Is this fixing an issue like:

  System.AggregateException: One or more errors occurred. (Code generation failed for method '[System.Collections]System.Collections.Generic.TreeSet`1<System.Collections.Generic.KeyValuePair`2<System.__Cano
  n,System.__Canon>>.AddIfNotPresent(KeyValuePair`2<__Canon,__Canon>)')
   ---> ILCompiler.CodeGenerationFailedException: Code generation failed for method '[System.Collections]System.Collections.Generic.TreeSet`1<System.Collections.Generic.KeyValuePair`2<System.__Canon,System.
  __Canon>>.AddIfNotPresent(KeyValuePair`2<__Canon,__Canon>)'
   ---> ILCompiler.ScannerFailedException: VTable of type 'System.Collections.Generic.TreeSet`1<System.Collections.Generic.KeyValuePair`2<System.__Canon, System.__Canon>>' not computed by the IL scanner. Yo
  u can work around by running the compilation with scanner disabled.
. . .

@MichalStrehovsky
Copy link
Member Author

Is this fixing an issue like:

No, this is just for the repro project.

I'm looking at the VTable of type 'System.Collections.Generic.TreeSet issue though. I think it's exposed by #73683 (I didn't verify, but it's likely). I understand what's the problem and working on a fix.

@MichalStrehovsky
Copy link
Member Author

@VSadov if it's blocking you, add a projectexclusion like Lakshan did in #73734. I'll have a fix soon.

@VSadov
Copy link
Member

VSadov commented Aug 12, 2022

It is blocking #73741, but it can wait till tomorrow.

@MichalStrehovsky MichalStrehovsky merged commit 6a2c63f into main Aug 12, 2022
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch August 12, 2022 07:53
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants