JIT: Fix generating unrepresentable nullchecks on ARM64 #71687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic in lowering could in some struct and primitive type cases generate an unrepresentable NULLCHECK node for ARM64/LA64, when there was a contained address mode. We now use the width from the address mode, if this keeps the access small enough, and otherwise clear containedness. Fix dotnet#71684
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThe logic in lowering could in some struct and primitive type cases Fix #71684
|
Avoid creating the address mode in the first place for unrepresentable accesses.
|
cc @dotnet/jit-contrib PTAL @EgorBo |
EgorBo
approved these changes
Jul 6, 2022
EgorBo
reviewed
Jul 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in lowering could in some struct and primitive type cases
generate an unrepresentable NULLCHECK node for ARM64/LA64 when there
was a contained address mode. We now transform unused indirections and
create address modes in the opposite order on non-xarch to avoid these unrepresentable
nullchecks.
Fix #71684