Fixing a typo in copying pdb files

[LakshanF]

Fixes dotnet/sdk#26349

[am11]

Ah, NativeBinaryExt is needed on Unix in this context, but not on Windows.

This should fix both:

  <Target Name="CopyNativeBinary" AfterTargets="Publish">
    <!-- replace apphost with binary we generated during native compilation -->
    <Delete Files="$(PublishDir)\$(TargetName)$(NativeBinaryExt)" />
    <Copy SourceFiles="$(NativeOutputPath)$(TargetName)$(NativeBinaryExt)" DestinationFolder="$(PublishDir)" />

    <!-- dotnet CLI produces managed debug symbols, which we will delete and copy native symbols instead -->
    <Delete Files="$(PublishDir)\$(TargetName).pdb" />

    <PropertyGroup>
      <_symbolExt Condition="'$(OS)' == 'Windows_NT'">$(NativeSymbolExt)</_symbolExt>
      <_symbolExt Condition="'$(OS)' != 'Windows_NT'">$(NativeBinaryExt)$(NativeSymbolExt)</_symbolExt>
    </PropertyGroup>

    <!-- replace native symbol file if it exists -->
    <Delete Files="$(PublishDir)\$(TargetName)$(_symbolExt)" />
    <Copy SourceFiles="$(NativeOutputPath)$(TargetName)$(_symbolExt)" DestinationFolder="$(PublishDir)"
      Condition="Exists('$(NativeOutputPath)$(TargetName)$(_symbolExt)')" />
  </Target>

[am11]

Thank you!

I have tested on linux with classlib and console projects and it works as expected (with -p:StripSymbols=true):

$ dotnet7 --version
7.0.100-preview.7.22324.4

$ dotnet7 new console -n nativeapp1
$ dotnet7 publish -c Release -o nativeapp1/dist --use-current-runtime -p:PublishAot=true -p:StripSymbols=true nativeapp1
$ ls -la nativeapp1/dist
 
total 15224
drwxrwxr-x 2 am11 am11     4096 Jun 30 01:07 .
drwxrwxr-x 5 am11 am11     4096 Jun 30 01:07 ..
-rwxrwxr-x 1 am11 am11  4878176 Jun 30 01:07 nativeapp1
-rwxrwxr-x 1 am11 am11 10701896 Jun 30 01:07 nativeapp1.dbg

$ readelf --string-dump=.gnu_debuglink nativeapp1/dist/nativeapp1

String dump of section '.gnu_debuglink':
  [     0]  nativeapp1.dbg
 
$ dotnet7 new classlib -n nativelib1
$ dotnet7 publish -c Release -o nativelib1/dist --use-current-runtime -p:PublishAot=true -p:StripSymbols=true -p:NativeLib=Shared nativelib1
$ ls -la nativelib1/dist

total 14488
drwxrwxr-x 2 am11 am11     4096 Jun 30 01:08 .
drwxrwxr-x 5 am11 am11     4096 Jun 30 01:08 ..
-rwxrwxr-x 1 am11 am11  4587888 Jun 30 01:08 nativelib1.so
-rwxrwxr-x 1 am11 am11 10233648 Jun 30 01:08 nativelib1.so.dbg

$ readelf --string-dump=.gnu_debuglink nativelib1/dist/nativelib1.so

String dump of section '.gnu_debuglink':
  [     0]  nativelib1.so.dbg

Would be nice to have a unit test in SDK repo which checks the presence of .dbg on Linux, .dwarf on macOS and .pdb on Windows.