Skip to content

Revert "Unpin locals (dotnet#70264)" #70627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2022
Merged

Revert "Unpin locals (dotnet#70264)" #70627

merged 1 commit into from
Jun 13, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jun 12, 2022 •
edited
Loading

Fixes #70626

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 12, 2022
@ghost ghost assigned jkotas Jun 12, 2022
@ghost
Copy link

ghost commented Jun 12, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: jkotas
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jkotas jkotas mentioned this pull request Jun 12, 2022
Closed
@jkotas jkotas force-pushed the revert branch 2 times, most recently from f2deb11 to ddc0b20 Compare June 12, 2022 20:52
@aromaa
Copy link
Contributor

aromaa commented Jun 12, 2022

Seems like #70264 doesn't play well with OSR and the JIT/opt/OSR/pinnedlocal/pinnedlocal.sh
 tests have been failing occasionally since the PR got merged. This most likely also effects lvIsBoolean but we might not have test coverage to expose it.

@jkotas
Copy link
Member Author

jkotas commented Jun 12, 2022

Seems like #70264 doesn't play well with OSR

Yes, it matches the symptoms that I am seeing. I am sorry I will have to revert #70264 to make the CI stable again.

@jkotas jkotas marked this pull request as ready for review June 12, 2022 21:47
@jkotas jkotas changed the title Investigating https://github.com/dotnet/runtime/issues/70626 InRevert "Unpin locals (dotnet#70264)" Jun 12, 2022
@jkotas jkotas changed the title InRevert "Unpin locals (dotnet#70264)" Revert "Unpin locals (dotnet#70264)" Jun 12, 2022
@jkotas
Copy link
Member Author

jkotas commented Jun 13, 2022

cc @dotnet/jit-contrib

@jkotas jkotas merged commit 4f81257 into dotnet:main Jun 13, 2022
@jkotas jkotas mentioned this pull request Jun 13, 2022
Closed
@SamMonoRT SamMonoRT mentioned this pull request Jun 16, 2022
Open
@jkotas jkotas deleted the revert branch June 18, 2022 00:12
@ghost ghost locked as resolved and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jkotas jkotas

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.IO.FileSystem tests crashing intermittently in CI
2 participants
@jkotas @aromaa