[release/7.0-preview5] Refactoring the generic-math CreateChecked/Saturating/Truncating APIs to match API review #70034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
added
the
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Corresponds to #64717 that I somehow missed, despite commenting on it. We still don't allow interfaces to implement methods of other interfaces. The CLR VM doesn't allow either.
|
CC. @jeffhandley |
tannergooding
added
the
Servicing-consider
tannergooding
removed
the
Servicing-consider
|
This was approved over email |
tannergooding
approved these changes
Jun 2, 2022
carlossanlop
approved these changes
Jun 2, 2022
|
Failures are unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #69756 and #69783 to release/7.0-preview5
/cc @tannergooding
Customer Impact
Generic Math is one of the bigger features for .NET 7 and this ensures that users can successfully create any of the built-in numeric types from any of the other built-in numeric types. Not having this change means that users need to wait another preview to validate the generic math feature including all the taken community feedback and updates given so far. The types covered by the create APIs are:
The 13 "runtime primitives":
byte,sbyteshort,ushortint,uintlong,ulongnint,nuintfloat,doublecharThe 5 "user-defined" types in corelib:
Int128,UInt128decimalHalfNFloatThere are then 2 more "user-defined" types outside corelib:
BigIntegerComplexTesting
This has tests covering the conversions from any
Tto anyUfor the various edge cases in both directions.Risk
Minimal, this touches a preview and is only available for use via new APIs.