Skip to content

[wasm] CI build improvements #69519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 20, 2022
Merged

[wasm] CI build improvements #69519

merged 11 commits into from
May 20, 2022

Conversation

radical
Copy link
Member

@radical radical commented May 18, 2022

  • Run all the debugger tests in one helix job, because most of them take a couple of minutes to run. And this would avoid the overhead of individual helix jobs

  • Add a no-workloads variant for Wasm.Build.Tests, instead of EMSDK

    • This replaces the job that used WasmApp.LocalBuild* stuff to build
      with a EMSDK checkout. That case already gets tested with library tests.
    • The EMSDK case had been disabled recently due to an Arcade issue
    • Since we have very few tests to run for the noworkloads case, they are
      all run in a single helix work item.

Fixes #58159
Fixes #67887 (by completely removing the EMSDK run)

@radical radical added NO-REVIEW Experimental/testing PR, do NOT review it arch-wasm WebAssembly architecture area-Build-mono labels May 18, 2022
@ghost ghost assigned radical May 18, 2022
@ghost
Copy link

ghost commented May 18, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

NO-REVIEW, arch-wasm, area-Build-mono

Milestone: -

@radical radical force-pushed the build-impr branch 2 times, most recently from 8f84e1d to 140b157 Compare May 18, 2022 22:33
@radical
Copy link
Member Author

radical commented May 18, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented May 19, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical force-pushed the build-impr branch 2 times, most recently from 53f5d5c to eaf977b Compare May 19, 2022 02:22
@radical
Copy link
Member Author

radical commented May 19, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented May 19, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented May 19, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

radical added 4 commits May 19, 2022 18:48
This replaces the job that used `WasmApp.LocalBuild*` stuff to build
with a EMSDK checkout. That case already gets tested with library tests.

Since we have very few tests to run for the noworkloads case, they are
all run in a single helix work item.
@radical radical changed the title [WIP][wasm] Build fixes [wasm] CI build improvements May 19, 2022
@radical radical added area-Debugger-mono and removed NO-REVIEW Experimental/testing PR, do NOT review it labels May 19, 2022
@ghost
Copy link

ghost commented May 19, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Run all the debugger tests in one helix job, because most of them take a couple of minutes to run. And this would avoid the overhead of individual helix jobs

  • Add a no-workloads variant for Wasm.Build.Tests, instead of EMSDK

    • This replaces the job that used WasmApp.LocalBuild* stuff to build
      with a EMSDK checkout. That case already gets tested with library tests.
    • The EMSDK case had been disabled recently due to an Arcade issue
    • Since we have very few tests to run for the noworkloads case, they are
      all run in a single helix work item.
Author: radical
Assignees: radical
Labels:

arch-wasm, area-Build-mono, area-Debugger-mono

Milestone: -

@radical radical requested a review from lewing May 19, 2022 19:07
@radical radical requested review from thaystg and radekdoulik May 19, 2022 19:07
@radical radical marked this pull request as ready for review May 19, 2022 19:07
@radical radical requested a review from marek-safar as a code owner May 19, 2022 19:07
@radical
Copy link
Member Author

radical commented May 19, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@thaystg thaystg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radical
Copy link
Member Author

radical commented May 20, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@radical
Copy link
Member Author

radical commented May 20, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@radical
Copy link
Member Author

radical commented May 20, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@radical
Copy link
Member Author

radical commented May 20, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical merged commit e4ac5cd into dotnet:main May 20, 2022
@radical radical deleted the build-impr branch May 20, 2022 22:18
@ghost ghost locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EMSDK-.WasmNativeDefaultsTests work item failing [wasm] Wasm.Build.Tests remove the *emsdk* run
2 participants