Skip to content

Remove exception messages from resource strings #59104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Sep 14, 2021

Cherry picks the change fcb684e introduced in #59097 back to main.

@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Sep 14, 2021
@eiriktsarpalis eiriktsarpalis self-assigned this Sep 14, 2021
@ghost
Copy link

ghost commented Sep 14, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Cherry picks the change introduced #59097.

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-System.Text.Json

Milestone: 7.0.0

Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmoseley
Copy link
Member

Approved. Customers currently rely on exception messages being unlocalized. Low risk.

would not meet the bar after today.

@danmoseley danmoseley added the Servicing-approved Approved for servicing release label Sep 15, 2021
@eiriktsarpalis eiriktsarpalis merged commit 82993d2 into dotnet:main Sep 15, 2021
@eiriktsarpalis eiriktsarpalis deleted the remove-exception-res-strings branch September 15, 2021 18:20
@eiriktsarpalis eiriktsarpalis removed the Servicing-approved Approved for servicing release label Sep 16, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants