Reflection nullability API: improve test coverage, fix bug found #58479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems it was worthwhile if you found a bug - great. |
stephentoub
reviewed
Sep 1, 2021
src/libraries/System.Private.CoreLib/src/System/Reflection/NullabilityInfoContext.cs
Outdated
Show resolved
Hide resolved
steveharter
reviewed
Sep 3, 2021
src/libraries/System.Private.CoreLib/src/System/Reflection/NullabilityInfoContext.cs
Show resolved
Hide resolved
steveharter
reviewed
Sep 3, 2021
src/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs
Show resolved
Hide resolved
buyaa-n
changed the title
buyaa-n
force-pushed
the
generics_nullability
branch
from
1608de1 to
027ceec
Compare
|
@stephentoub I don't believe @steveharter is available to review this. Could you re-review please? |
|
@stephentoub @steveharter comments addressed, please take another look |
stephentoub
reviewed
Sep 10, 2021
src/libraries/System.Private.CoreLib/src/System/Reflection/NullabilityInfoContext.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Sep 11, 2021
Anipik
pushed a commit
that referenced
this pull request
Sep 14, 2021
…58390) * Set generic type arguments nullability for value types * Skip test on mono * Apply commment * Separate var name parts with _ * Reflection nullability API: improve test coverage, fix bug found (#58479) * Add/remove some tests, fix generics indexing bug Co-authored-by: Buyaa Namnan <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #58390 (comment) cc @danmoseley
Reflection nullability context API updates