Expand PriorityQueue test coverage #48420

eiriktsarpalis · 2021-02-17T21:30:50Z

Extends PriorityQueue test coverage in the following ways:

Abstracts the IComparer<TPriority> parameter in the PriorityQueue generic test class so that all code paths added in PriorityQueue: Apply Comparer<T>.Default optimization #48346 are exercised.
Adds a few missing unit tests.
Minor refactorings and rearrangements of existing tests.
Adds property tests for PriorityQueue, a form of structured fuzzing already used in the Cbor project.

does minor refactorings and adds new tests

ghost · 2021-02-17T21:30:56Z

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Extends PriorityQueue test coverage in the following ways:

Abstracts the IComparer<TPriority> parameter in the PriorityQueue generic test class so that all code paths added in PriorityQueue: Apply Comparer<T>.Default optimization #48346 are exercised.
Adds a few missing unit tests.
Minor refactorings and rearrangements of existing tests.
Adds property tests for PriorityQueue, a form of structured fuzzing already used in the Cbor project.

src/libraries/System.Collections/tests/Generic/PriorityQueue/PriorityQueue.Generic.Tests.cs

src/libraries/System.Collections/tests/Generic/PriorityQueue/PriorityQueue.PropertyTests.cs

src/libraries/System.Collections/tests/System.Collections.Tests.csproj

stephentoub

Thanks.

eiriktsarpalis added 3 commits February 17, 2021 21:15

make comparer field readonly

22aa959

abstract IComparer in PriorityQueue generic tests

7038345

does minor refactorings and adds new tests

add PriorityQueue property tests

bce2db9

ghost added the area-System.Collections label Feb 17, 2021

eiriktsarpalis requested a review from stephentoub February 17, 2021 21:30

eiriktsarpalis self-assigned this Feb 17, 2021