Skip to content

skip SslStream_ClientCertificate_SendsChain test if chain is not valid #48261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2021
Merged

skip SslStream_ClientCertificate_SendsChain test if chain is not valid #48261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9470757
skip SslStream_ClientCertificate_SendsChain test if chain is not valid
wfurt Feb 13, 2021
4b55d81
make test conditional
wfurt Feb 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamNetworkStreamTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ public async Task SslStream_UntrustedCaWithCustomCallback_Throws(bool customCall
}
}

[Fact]
[ConditionalFact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/46837", TestPlatforms.OSX)]
public async Task SslStream_ClientCertificate_SendsChain()
{
Expand All @@ -371,7 +371,10 @@ public async Task SslStream_ClientCertificate_SendsChain()
chain.ChainPolicy.DisableCertificateDownloads = false;
bool chainStatus = chain.Build(clientCertificate);
// Verify we can construct full chain
Assert.True(chain.ChainElements.Count >= clientChain.Count, "chain cannot be built");
if (chain.ChainElements.Count < clientChain.Count)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You said "for now" in the description. Is there an issue this should be tracked against?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will leave #48091 open so that should be used for tracking.

{
throw new SkipTestException($"chain cannot be built {chain.ChainElements.Count}");
}
}

var clientOptions = new SslClientAuthenticationOptions() { TargetHost = "localhost", };
Expand Down