Skip to content

Return failure code when SafeHandle tests fail. #48083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from
Feb 10, 2021

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT added test-bug Problem in test source code (most likely) area-Interop-coreclr labels Feb 9, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 6.0.0 milestone Feb 9, 2021
@AaronRobinsonMSFT
Copy link
Member Author

This test will fail on Mono and will require some investigation as to how it should be fixed. The following is one of the reasons:

CoreCLR: System.Runtime.InteropServices.MarshalDirectiveException: Cannot marshal 'parameter #1': Ref and out SafeHandle parameters cannot be abstract.

Mono: System.MemberAccessException: Cannot create an abstract class: SafeHandleTests.AbstractDerivedSafeHandle

After the above exception disparities are reconciled the next issue is an A/V for the following P/Invoke dispatch:

[DllImport(nameof(SafeHandleNative), PreserveSig = false)]
public static extern TestSafeHandle SafeHandleReturn_Swapped(IntPtr expectedValue);

Given the above issues on a local run I am going to disable the SafeHandles test on Mono in issues.targets.

@AaronRobinsonMSFT AaronRobinsonMSFT added disabled-test The test is disabled in source code against the issue auto-merge and removed disabled-test The test is disabled in source code against the issue labels Feb 9, 2021
@ghost
Copy link

ghost commented Feb 9, 2021

Hello @AaronRobinsonMSFT!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 168d109 into dotnet:master Feb 10, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the enable_safehandle_failures branch February 10, 2021 04:45
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Interop-coreclr test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants