-
Notifications
You must be signed in to change notification settings - Fork 5k
Move corehost under src/native #48071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @vitek-karas, @agocke Issue DetailsCommits:
|
I do not think failures in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the same changes as in #45765
LGTM
|
Thank you!! |
Sorry for the post-merge discussion but did we also consider instead of having a distinct directory just for native files, putting all host related files together? Mostly talking about the corehost.proj msbuild wrapper file and the nuget package files (the pkgprojs). |
I have subscribed to your #48338 thread for that. 😄 |
Ok cool, so we aren't concerned about having msbuild files under eng/native? That works for me :)
Haha cool. I just marked it as up for grabs as it shouldn't be too hard to accomplish. There are different strategical investments going forward to minimize the installer subset and move it into other more suitable places in the repo. I.e. the refpack could just be built by libraries. |
Commits: