Skip to content

Move corehost under src/native #48071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2021
Merged

Move corehost under src/native #48071

merged 4 commits into from
Feb 13, 2021

Conversation

am11
Copy link
Member

@am11 am11 commented Feb 9, 2021

Commits:

  • Move corehost under src/native
  • Move content out of cli/ directory
  • Update configurations post-move
  • Update docs

@ghost ghost added the area-Host label Feb 9, 2021
@ghost
Copy link

ghost commented Feb 9, 2021

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

Issue Details

Commits:

  • Move corehost under src/native
  • Move content out of cli/ directory
  • Update configurations post-move
  • Update docs
Author: am11
Assignees: -
Labels:

area-Host

Milestone: -

@VSadov
Copy link
Member

VSadov commented Feb 12, 2021

I do not think failures in Libraries Build windows allConfigurations x64 Debug caused by the changes. Perhaps needs rebasing once more?

Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the same changes as in #45765
LGTM

@am11
Copy link
Member Author

am11 commented Feb 13, 2021

Linux_musl arm failure is #48091.

@VSadov VSadov merged commit 5d04c9e into dotnet:master Feb 13, 2021
@VSadov
Copy link
Member

VSadov commented Feb 13, 2021

Thank you!!

@ViktorHofer
Copy link
Member

Sorry for the post-merge discussion but did we also consider instead of having a distinct directory just for native files, putting all host related files together? Mostly talking about the corehost.proj msbuild wrapper file and the nuget package files (the pkgprojs).

@am11
Copy link
Member Author

am11 commented Feb 20, 2021

I have subscribed to your #48338 thread for that. 😄
basically, once we get the git rev-parse ExecCommand and friends decoupled from corehost and rest of the projects under src/installer, it would make it possible to move the corehost.proj file under src/native, without duplicating the common installer targets. I haven't looked at pkgprojs, but once/if corehost.proj is moved, it's easy to decouple pkgprojs as well (unless there is some correlation with sfxprojs which might make it more.. exciting to figure out).

@am11 am11 deleted the feature/corehost-to-src-native branch February 20, 2021 09:11
@ViktorHofer
Copy link
Member

Ok cool, so we aren't concerned about having msbuild files under eng/native? That works for me :)

I have subscribed to your #48338 thread for that. 😄

Haha cool. I just marked it as up for grabs as it shouldn't be too hard to accomplish. There are different strategical investments going forward to minimize the installer subset and move it into other more suitable places in the repo. I.e. the refpack could just be built by libraries.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants