Skip to content

[mbr] Add a global has_updates flag #47716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

lambdageek
Copy link
Member

Use it to take the slow path in metadata lookups when there's at least one delta applied.

Use it to take the slow path in metadata lookups when there's at least one
delta applied.
@ghost
Copy link

ghost commented Feb 1, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

Use it to take the slow path in metadata lookups when there's at least one delta applied.

Author: lambdageek
Assignees: -
Labels:

area-VM-meta-mono

Milestone: -

@lambdageek
Copy link
Member Author

This is in part motivated by #46842 perf results, and in part by some future changes that will affect the effective table lookup.

I was able to identify some differences in profiles, primarily due to profiler choices around mono_metadata_decode_row and mono_metadata_decode_row_col. I added #47716, but it doesn't not alter the run times in any meaningful way. (it does nudge the xcode clang inliner to the same choices as before, so the profile stack traces look more similar, and I think it's better to logically separate the slow path with an explicit state change.)

@lambdageek lambdageek merged commit b89341d into dotnet:master Feb 2, 2021
@lambdageek lambdageek deleted the mbr-global-modified branch February 2, 2021 15:18
@ghost ghost locked as resolved and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants