Skip to content

Create more informational assert collection log for FunctionalTests o… #44350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lateapexearlyspeed
Copy link
Contributor

…f FileSystemGlobbing.

Hello, this PR is for #44281 .

I verified in my local pc with this helper method in that test project by intentionally changing expected count or updating one item value. It will give more information than before. Also seems some other runtime projects were already using Assert.Collection(). I wrap this method into a 'private static void AssertCollection(IEnumerable expected, IEnumerable actual)' and use it in specified test file.

Please review and give suggestion if need, so that I can update code correspondingly, thanks very much and hope have a try to contribute .Net !

@dnfadmin
Copy link

dnfadmin commented Nov 6, 2020

CLA assistant check
All CLA requirements met.

@ghost
Copy link

ghost commented Nov 7, 2020

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

@danmoseley
Copy link
Member

I'll let @maryamariyan review this one. :)

@lateapexearlyspeed
Copy link
Contributor Author

lateapexearlyspeed commented Nov 24, 2020

Hi @maryamariyan Seems CI pipeline was blocked by CI issue and was mentioned in #32805; also the check 'runtime (Libraries Build windows allConfigurations x64 Debug)' was being in progress from "4d 23h ago".

Is there any way I can re-trigger CI build besides of pushing a new commit, what is action I should do now, thanks.

@danmoseley
Copy link
Member

You can close and reopen the PR.

@lateapexearlyspeed
Copy link
Contributor Author

Hi @danmosemsft Thanks for tip :) All checks passed now. Any more comment, can it be merged ?

@danmoseley
Copy link
Member

@maryamariyan ?

@lateapexearlyspeed
Copy link
Contributor Author

Hi @maryamariyan Any chance you can have a look at this PR? :)

@maryamariyan
Copy link
Member

Thanks for the update @lateapexearlyspeed. Looking now

Copy link
Member

@maryamariyan maryamariyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach LGTM with some nit comments.
Thanks @lateapexearlyspeed for the contribution. We'll make sure next follow ups are faster :)

@danmoseley
Copy link
Member

@maryamariyan is this good to merge?

@maryamariyan maryamariyan merged commit 31062e4 into dotnet:master Dec 14, 2020
@maryamariyan
Copy link
Member

It's merged now. Thank you!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants