-
Notifications
You must be signed in to change notification settings - Fork 5k
Create more informational assert collection log for FunctionalTests o… #44350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create more informational assert collection log for FunctionalTests o… #44350
Conversation
…f FileSystemGlobbing.
src/libraries/Microsoft.Extensions.FileSystemGlobbing/tests/FunctionalTests.cs
Outdated
Show resolved
Hide resolved
Tagging subscribers to this area: @maryamariyan |
…nd use it in FunctionalTests.
…issue-44281-CreateInformationalCollectionAssert
I'll let @maryamariyan review this one. :) |
…ms, no matter order.
src/libraries/Common/tests/TestUtilities/System/AssertExtensions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/TestUtilities/System/AssertExtensions.cs
Outdated
Show resolved
Hide resolved
…issue-44281-CreateInformationalCollectionAssert
Hi @maryamariyan Seems CI pipeline was blocked by CI issue and was mentioned in #32805; also the check 'runtime (Libraries Build windows allConfigurations x64 Debug)' was being in progress from "4d 23h ago". Is there any way I can re-trigger CI build besides of pushing a new commit, what is action I should do now, thanks. |
You can close and reopen the PR. |
Hi @danmosemsft Thanks for tip :) All checks passed now. Any more comment, can it be merged ? |
Hi @maryamariyan Any chance you can have a look at this PR? :) |
Thanks for the update @lateapexearlyspeed. Looking now |
src/libraries/Common/tests/TestUtilities/System/AssertExtensions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/TestUtilities/System/AssertExtensions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/TestUtilities/System/AssertExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach LGTM with some nit comments.
Thanks @lateapexearlyspeed for the contribution. We'll make sure next follow ups are faster :)
…ns.cs Change var to int. Co-authored-by: Maryam Ariyan <[email protected]>
@maryamariyan is this good to merge? |
It's merged now. Thank you! |
…f FileSystemGlobbing.
Hello, this PR is for #44281 .
I verified in my local pc with this helper method in that test project by intentionally changing expected count or updating one item value. It will give more information than before. Also seems some other runtime projects were already using Assert.Collection(). I wrap this method into a 'private static void AssertCollection(IEnumerable expected, IEnumerable actual)' and use it in specified test file.
Please review and give suggestion if need, so that I can update code correspondingly, thanks very much and hope have a try to contribute .Net !