Fix ilasm managed resource lookup on Linux. #42735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
jkotas
added
area-ILTools-coreclr
and removed
area-CodeGen-coreclr
janvorli
reviewed
Sep 30, 2020
|
@mlindstr thank you for your contribution. I have noticed that there are four other places in ilasm that use |
ILAsm did not properly find managed resources if they were not in the working directory of ILAsm itself. While there was a provision for Windows-based systems using backslashes as directory separators, there was no such provision for *nix-based systems using forward slashes. This commit enables ILAsm to lookup using both types of directory separators.
This fixes path handling on *nix targets.
|
|
janvorli
approved these changes
Oct 5, 2020
|
The "Libraries Test Run checked coreclr Linux x64 Debug" failed due to unrelated #43166 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ILAsm did not properly find managed resources if they were not in the
working directory of ILAsm itself. While there was a provision for
Windows-based systems using backslashes as directory separators, there
was no such provision for *nix-based systems using forward slashes.
This commit enables ILAsm to lookup using both types of directory
separators.