-
Notifications
You must be signed in to change notification settings - Fork 5k
Remove net5 feeds #41620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove net5 feeds #41620
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
@ViktorHofer is this good to merge? |
Tagging subscribers to this area: @ViktorHofer |
Nope... Need to work with @mmitche to get the non-flowing packages into the net6 feeds. Hasn't been a priority yet. |
@ericstj I don't think we want to continue using a netstandard 2.2 prerelease package. Should we downgrade our usage to the latest 2.1 released package? |
So long as that works with source build. @dseefeld |
This should work for source-build. netstandard.library.ref 2.1.0 is built in source-build-reference-packages. |
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
ada61b1
to
beb3109
Compare
@dotnet/runtime-infrastructure who knows which component pushes the optimization data to the dotnet5 feed? We need to update that to the dotnet6 feed. AFAIK |
The internal dotnet-optimization repo produces the optimization data. |
That pipeline has been failing since 9/29: https://dev.azure.com/dnceng/internal/_build?definitionId=237. Who ones that repo/infra? |
@agocke is working now on getting it back online. |
I can probably route as appropriate |
Hoping to get it done this week, just getting up to speed. |
beb3109
to
9f85597
Compare
@agocke any update on the optimization internal repo? |
I've made several fixes and have now run into a runtime crash that's blocking. Stack looks like: coreclr.dll!ClrFree(void * p) Line 302 C++
coreclr.dll!operator delete[](void * p) Line 410 C++
coreclr.dll!MulticoreJitRecorder::WriteOutput(IStream * pStream) Line 557 C++
coreclr.dll!MulticoreJitRecorder::WriteOutput() Line 155 C++
coreclr.dll!MulticoreJitRecorder::StopProfile(bool) Line 951 C++
coreclr.dll!MulticoreJitRecorder::WriteMulticoreJitProfiler(_TP_CALLBACK_INSTANCE * pInstance, void * pvContext, _TP_TIMER * pTimer) Line 810 C++ I'm working to try to get a time-travel debugging repro, but I'm unfamiliar with the system so it may take a bit. |
This is now blocked on #46778 |
@agocke looks like the related issue was fixed yesterday. I'm unsure how the optimization repo consumes new builds but I assume you are now unblocked? |
I hope so, testing today |
optimization should be unblocked and completing builds now |
/azp run runtime-live-build |
No pipelines are associated with this pull request. |
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
I manually pushed the latest optimization packages to the dotnet6-transport feed as bits are still not flowing from the optimization repo. |
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run dotnet-linker-tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-staging |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-dev-innerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
9f85597
to
7650429
Compare
@dotnet/runtime-infrastructure this PR should be ready now. Would be great if you could approve. Thanks We now know that the only dependencies that don't flow automatically are the optimization.* and the intellisense packages. Hopefully we can get the optimization ones hooked up onto dependency flow properly. The intellisense one afaik should go away anyway. |
Failure is #32805 |
Fixes #41593
Depends on #43304
List of not flowing packages in the dotnet* feeds (in-complete):
cc @mmitche