Skip to content

Remove net5 feeds #41620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Remove net5 feeds #41620

merged 1 commit into from
Feb 16, 2021

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Aug 31, 2020

Fixes #41593
Depends on #43304

List of not flowing packages in the dotnet* feeds (in-complete):

  • microsoft.private.intellisense
  • optimization.*

cc @mmitche

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ViktorHofer
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@danmoseley
Copy link
Member

@ViktorHofer is this good to merge?

@ghost
Copy link

ghost commented Oct 11, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@ViktorHofer
Copy link
Member Author

Nope... Need to work with @mmitche to get the non-flowing packages into the net6 feeds. Hasn't been a priority yet.

@ViktorHofer
Copy link
Member Author

netstandard.library

@ericstj I don't think we want to continue using a netstandard 2.2 prerelease package. Should we downgrade our usage to the latest 2.1 released package?

@ericstj
Copy link
Member

ericstj commented Oct 12, 2020

latest 2.1 released package

So long as that works with source build. @dseefeld

@dseefeld
Copy link
Contributor

latest 2.1 released package

So long as that works with source build. @dseefeld Dan Seefeldt FTE

This should work for source-build. netstandard.library.ref 2.1.0 is built in source-build-reference-packages.

@ViktorHofer
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Nov 30, 2020
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 30, 2020
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 30, 2020
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 30, 2020
@ViktorHofer ViktorHofer force-pushed the ViktorHofer-net5feeds branch from ada61b1 to beb3109 Compare December 10, 2020 18:25
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Dec 10, 2020

@dotnet/runtime-infrastructure who knows which component pushes the optimization data to the dotnet5 feed? We need to update that to the dotnet6 feed.

AFAIK microsoft.private.intellisense is published manually into our feed, hence we should manually publish the latest version into dotnet6 and update guidance.

@jkoritzinsky
Copy link
Member

The internal dotnet-optimization repo produces the optimization data.

@ViktorHofer
Copy link
Member Author

The internal dotnet-optimization repo produces the optimization data.

That pipeline has been failing since 9/29: https://dev.azure.com/dnceng/internal/_build?definitionId=237. Who ones that repo/infra?

@jkoritzinsky
Copy link
Member

@agocke is working now on getting it back online.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Dec 10, 2020

@agocke is working now on getting it back online.

Should we track this pipeline in the CI Council dashboard? I assume it's @mmitche or @Anipik who did the default channel remapping from dotnet5 to dotnet6 back then? Who would the point of contact for that repo in general?

@agocke
Copy link
Member

agocke commented Dec 10, 2020

I can probably route as appropriate

@ViktorHofer
Copy link
Member Author

I can probably route as appropriate

Thanks a lot @agocke. Do you have an ETA when the repo will be unblocked?

I will speak with @Chrisboh to include the optimization pipeline to the internal dashboard to track it going forward.

@agocke
Copy link
Member

agocke commented Dec 10, 2020

Hoping to get it done this week, just getting up to speed.

@ViktorHofer ViktorHofer force-pushed the ViktorHofer-net5feeds branch 2 times, most recently from beb3109 to 9f85597 Compare December 16, 2020 13:21
@ViktorHofer
Copy link
Member Author

@agocke any update on the optimization internal repo?

@agocke
Copy link
Member

agocke commented Jan 7, 2021

I've made several fixes and have now run into a runtime crash that's blocking. Stack looks like:

coreclr.dll!ClrFree(void * p) Line 302 C++
coreclr.dll!operator delete[](void * p) Line 410 C++
coreclr.dll!MulticoreJitRecorder::WriteOutput(IStream * pStream) Line 557 C++
coreclr.dll!MulticoreJitRecorder::WriteOutput() Line 155 C++
coreclr.dll!MulticoreJitRecorder::StopProfile(bool) Line 951 C++
coreclr.dll!MulticoreJitRecorder::WriteMulticoreJitProfiler(_TP_CALLBACK_INSTANCE * pInstance, void * pvContext, _TP_TIMER * pTimer) Line 810 C++

I'm working to try to get a time-travel debugging repro, but I'm unfamiliar with the system so it may take a bit.

@agocke
Copy link
Member

agocke commented Jan 11, 2021

This is now blocked on #46778

@ViktorHofer
Copy link
Member Author

@agocke looks like the related issue was fixed yesterday. I'm unsure how the optimization repo consumes new builds but I assume you are now unblocked?

@agocke
Copy link
Member

agocke commented Jan 12, 2021

I hope so, testing today

@agocke
Copy link
Member

agocke commented Jan 13, 2021

optimization should be unblocked and completing builds now

@ViktorHofer ViktorHofer self-assigned this Feb 15, 2021
@ViktorHofer
Copy link
Member Author

/azp run runtime-live-build

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@ViktorHofer
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

I manually pushed the latest optimization packages to the dotnet6-transport feed as bits are still not flowing from the optimization repo.

@ViktorHofer
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

/azp run dotnet-linker-tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer ViktorHofer removed the blocked Issue/PR is blocked on something - see comments label Feb 16, 2021
@ViktorHofer
Copy link
Member Author

/azp run runtime-staging

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

/azp run runtime-dev-innerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer ViktorHofer force-pushed the ViktorHofer-net5feeds branch from 9f85597 to 7650429 Compare February 16, 2021 14:20
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Feb 16, 2021

@dotnet/runtime-infrastructure this PR should be ready now. Would be great if you could approve. Thanks

We now know that the only dependencies that don't flow automatically are the optimization.* and the intellisense packages. Hopefully we can get the optimization ones hooked up onto dependency flow properly. The intellisense one afaik should go away anyway.

@ViktorHofer
Copy link
Member Author

Failure is #32805

@ViktorHofer ViktorHofer merged commit 71d1aad into master Feb 16, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-net5feeds branch February 16, 2021 18:53
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dotnet5* feeds from NuGet.config in master
8 participants