Fix logic in compareTypesForCast #31681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't careful enough with `__Canon` in some cases, which lead to unsafely returning `MustNot` when the cast outcome was not determined at jit time. Add an extra check, update comments, and add some test cases. Addresses the failures seen in dotnet#1195 (which was reverted).
|
NOTE: probably makes sense to return |
jkotas
reviewed
Feb 3, 2020
jkotas
reviewed
Feb 3, 2020
|
Formatting failure seems bogus; I did not change the code in the jit, and the patch file produced is empty. |
jkotas
added
the
area-CodeGen-coreclr
|
x86 libraries "System.Threading.Tasks.Tests Work Item" has failed twice now, leaving no diagnostic output to work with. Fairly sure this is unrelated to this change and it fails intermittently in master too. Looks like this could be #2271 -- both failures in the above CI runs happen just after the 15 min mark.
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't careful enough with
__Canonin some cases, which lead to unsafelyreturning
MustNotwhen the cast outcome was not determined at jit time.Add an extra check, update comments, and add some test cases.
Addresses the failures seen in #1195 (which was reverted).