-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add System.Formats.Cbor to the ASP.NET Core transport package #116602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR unblocks a related issue by adding the System.Formats.Cbor dependency to the ASP.NET Core transport package.
- Added the System.Formats.Cbor dependency to the NetCoreAppLibrary.props file.
Comments suppressed due to low confidence (1)
src/libraries/NetCoreAppLibrary.props:226
- [nitpick] Consider adding a brief comment explaining the inclusion of System.Formats.Cbor to aid future maintainers in understanding its purpose in this transport package.
System.Formats.Cbor;
wtgodbe
approved these changes
Jun 12, 2025
ericstj
approved these changes
Jun 16, 2025
/ba-g dead lettered iOS/tvos tests. Unlikely to be caused by this PR. Cannot be excused with known issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks dotnet/aspnetcore#62112