Skip to content

Add System.Formats.Cbor to the ASP.NET Core transport package #116602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2025

Conversation

MackinnonBuck
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings June 12, 2025 20:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR unblocks a related issue by adding the System.Formats.Cbor dependency to the ASP.NET Core transport package.

  • Added the System.Formats.Cbor dependency to the NetCoreAppLibrary.props file.
Comments suppressed due to low confidence (1)

src/libraries/NetCoreAppLibrary.props:226

  • [nitpick] Consider adding a brief comment explaining the inclusion of System.Formats.Cbor to aid future maintainers in understanding its purpose in this transport package.
System.Formats.Cbor;

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 12, 2025
@ericstj
Copy link
Member

ericstj commented Jun 16, 2025

/ba-g dead lettered iOS/tvos tests. Unlikely to be caused by this PR. Cannot be excused with known issue.

@ericstj ericstj merged commit 528b402 into main Jun 16, 2025
80 of 86 checks passed
@jkotas jkotas deleted the mbuck/add-cbor-to-aspnetcore-transport branch June 19, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants