-
Notifications
You must be signed in to change notification settings - Fork 5k
Fix Idn failing tests #115018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Idn failing tests #115018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses failing tests by updating the ICU version threshold for selecting the appropriate IdnaTest file.
- Lower the version threshold for selecting "IdnaTest_15_1.txt" to 72.
- Adjust the test configuration in the Factory.cs file to match expected ICU behavior.
...raries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs
Show resolved
Hide resolved
Tagging subscribers to this area: @dotnet/area-system-globalization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are also failing in the prev4 branch. Can you please backport? It would be tell-mode, I can merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it fixes the issue. Seems like we're updating based on observation of which ICU versions we see in the places we test - anything we need to do to look at the ICU build / repo to find exact version where this change was introduced?
Confirmed it's also affecting prev4: https://github.com/dotnet/runtime/pull/114979/checks?check_run_id=41117511379 |
Yes, I opened the issue based on a P4 PR |
/backport to release/10.0-preview4 |
Started backporting to release/10.0-preview4: https://github.com/dotnet/runtime/actions/runs/14652881804 |
/backport to release/9.0-staging |
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14653792031 |
@tarekgh backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix Idn failing tests
Using index info to reconstruct a base tree...
M src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs
CONFLICT (content): Merge conflict in src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Fix Idn failing tests
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
Fixes #115006