-
Notifications
You must be signed in to change notification settings - Fork 5k
Fix CA2256 in COM generator when using 'ManagedObjectWrapper' #114642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jkoritzinsky
merged 2 commits into
dotnet:main
from
Sergio0694:user/sergiopedri/fix-90922
Apr 15, 2025
Merged
Fix CA2256 in COM generator when using 'ManagedObjectWrapper' #114642
jkoritzinsky
merged 2 commits into
dotnet:main
from
Sergio0694:user/sergiopedri/fix-90922
Apr 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComInterfaceGenerator.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComInterfaceGenerator.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 14, 2025
9df77c3
to
699dc50
Compare
Sergio0694
commented
Apr 14, 2025
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComInterfaceGenerator.cs
Show resolved
Hide resolved
699dc50
to
dee988e
Compare
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComInterfaceGenerator.cs
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Apr 15, 2025
jkoritzinsky
approved these changes
Apr 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Runtime.InteropServices
community-contribution
Indicates that the PR has been added by a community member
source-generator
Indicates an issue with a source generator feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #90922
This PR updates the COM generator to not produce a warning when using
ManagedObjectWrapper
.