Fix non-portable build for < OpenSSL 3.4 #113965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build was checking to see if HAVE_OPENSSL_EVP_PKEY_SIGN_MESSAGE_INIT was defined, however because we use cmakedefine01 in the build, it is always defined. We care about the value of the define, not if it is defined or not.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- src/native/libs/System.Security.Cryptography.Native/openssl.c: Language not supported
- src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey_ml_dsa.c: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
krwq
approved these changes
Mar 27, 2025
|
Thanks @vcsjones! I verified this fixes #113764 (comment). |
bartonjs
approved these changes
Mar 27, 2025
|
/ba-g Unrelated, known failures. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build was checking to see if HAVE_OPENSSL_EVP_PKEY_SIGN_MESSAGE_INIT was defined, however because we use cmakedefine01 in the build, it is always defined. We care about the value of the define, not if it is defined or not. This is different from
NEED_OPENSSL_3_0, which uses the presence of the define or not./cc @tmds @omajid since y'all reported the initial build break.