Fix resetting for JIT retry #113842
Merged
Fix resetting for JIT retry #113842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made a mistake in my recent PR where the `ResetForJitRetry` method on a new base class was not marked as virtual by accident. So the JIT specific version was not executed and part of the state was not reset. Close dotnet#113840
janvorli
added
the
area-CodeGen-coreclr
jakobbotsch
approved these changes
Mar 24, 2025
|
/ba-g The CI issues seem to be #113785 and are unrelated to this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a mistake in my recent PR where the
ResetForJitRetrymethod on a new base class was not marked as virtual by accident. So the JIT specific version was not executed and part of the state was not reset.Close #113840