Revert "Refactor external_assembly_probe to be separate from single-file bundle probing"
#113738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-file bu…" This reverts commit 035ee5c.
ghost
added
the
There was a problem hiding this comment.
Copilot reviewed 1 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (20)
- src/coreclr/binder/assemblybindercommon.cpp: Language not supported
- src/coreclr/binder/inc/assembly.hpp: Language not supported
- src/coreclr/binder/inc/assemblybindercommon.hpp: Language not supported
- src/coreclr/dlls/mscoree/exports.cpp: Language not supported
- src/coreclr/inc/assemblyprobeextension.h: Language not supported
- src/coreclr/inc/bundle.h: Language not supported
- src/coreclr/inc/hostinformation.h: Language not supported
- src/coreclr/vm/CMakeLists.txt: Language not supported
- src/coreclr/vm/assemblynative.cpp: Language not supported
- src/coreclr/vm/assemblyprobeextension.cpp: Language not supported
- src/coreclr/vm/assemblyspec.cpp: Language not supported
- src/coreclr/vm/bundle.cpp: Language not supported
- src/coreclr/vm/coreassemblyspec.cpp: Language not supported
- src/coreclr/vm/hostinformation.cpp: Language not supported
- src/coreclr/vm/nativeimage.cpp: Language not supported
- src/coreclr/vm/peassembly.cpp: Language not supported
- src/coreclr/vm/peassembly.inl: Language not supported
- src/coreclr/vm/peimage.cpp: Language not supported
- src/coreclr/vm/peimage.h: Language not supported
- src/coreclr/vm/peimage.inl: Language not supported
|
Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov |
akoeplinger
approved these changes
Mar 20, 2025
|
note that this change is also in preview3... |
|
Should I target this to p3 first? what's our usual strategy? |
agocke
requested review from
jeffhandley,
lewing,
pavelsavara,
steveisok,
vitek-karas,
BrzVlad,
lateralusX,
thaystg and
MichalStrehovsky
as code owners
|
OK, I'm going to merge it in |
|
/ba-g tests were already run and failures were unrelated |
|
/backport to release/10.0-preview3 |
|
Started backporting to release/10.0-preview3: https://github.com/dotnet/runtime/actions/runs/13980033827 |
4 tasks
That's what we usually do yes. |
This was referenced Mar 20, 2025
elinor-fung
added a commit
to elinor-fung/runtime
that referenced
this pull request
Mar 21, 2025
…e-file bu…" (dotnet#113738) This reverts commit 1511811.
elinor-fung
added a commit
that referenced
this pull request
Mar 25, 2025
…e-file bundle probing" (#113776) Undo the revert in #113738 Fix on top of the original: Make a copy of the host contract information on initialization instead of just operating on a pointer to the struct. This should address intermittent failures on shutdown where a thread is still running after coreclr_shutdown has completed and the actual contract struct provided by a host may be cleaned up. The assumption is that any function pointers provided on the host contract at initialization should remain valid for the process lifetime.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #113356
Looks like this is causing a failure in the VMR build: dotnet/source-build#4952