Skip to content

[browser][Windows] Assembly reference with Unicode path cannot be resolved on Windows #111711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 27, 2025

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jan 22, 2025

Fixes #110482

We are enabling long paths in helix but WasmBuildTests are running inside of docker (image: mcr.microsoft.com/dotnet-buildtools/prereqs:windowsservercore-ltsc2022-helix-webassembly). We could edit the image to enable the long paths but that could break other tests that are specifically testing long paths. For this test, we can work it around by shortening the assembly path and log an issue about this problem.

@ilonatommy
Copy link
Member Author

ilonatommy commented Jan 23, 2025

The path it's complaining about is 262 chars:
C:\helix\work\workitem\e\wbt artifacts\nuget\blz_dllimp_Release_鿀蜒枛遫䡫煉build_then_publish_Release_False_qrkfikty_pdq_鿀蜒枛遫䡫煉\microsoft.extensions.configuration.fileextensions\10.0.0-alpha.1.24569.15\lib\net10.0\Microsoft.Extensions.Configuration.FileExtensions.dll
The limit of chars for assembly name is 260. Locally, when testing, MAX_PATH is disabled. This would explain why the failures are restricted to CI. It is possible that on the helix machine, the max path limitation is not disabled.

@ilonatommy
Copy link
Member Author

LongPathsEnabled check on Windows's machine:
log

long path enabled -> False

@ilonatommy ilonatommy added this to the 10.0.0 milestone Jan 24, 2025
@ilonatommy
Copy link
Member Author

ilonatommy commented Jan 27, 2025

The change did not shorten the path enough for some .dlls, e.g. C:\helix\work\workitem\e\wbt artifacts\nuget\dllimp_Release_鿀蜒枛遫䡫煉build_then_publish_Release_False_on1vy5gd_4mf_鿀蜒枛遫䡫煉\microsoft.extensions.dependencyinjection.abstractions\10.0.0-alpha.1.24569.15\lib\net10.0\Microsoft.Extensions.DependencyInjection.Abstractions.dll. It's best to revert the shortening and see if dotnet/dotnet-buildtools-prereqs-docker#1328 fixed it.

@ilonatommy ilonatommy marked this pull request as ready for review January 27, 2025 11:27
@ilonatommy ilonatommy requested a review from maraf as a code owner January 27, 2025 11:27
@ilonatommy ilonatommy merged commit 2e42b6e into dotnet:main Jan 27, 2025
27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[browser][Windows] Assembly reference with Unicode path cannot be resolved on Windows
2 participants