Fix the condition to exclude only native shared libs #109676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
am11
added
area-Setup
and removed
needs-area-label
akoeplinger
approved these changes
Nov 10, 2024
| @@ -26,7 +26,7 @@ | |||
| <ItemGroup Condition="'$(PackageTargetRuntime)' != ''"> | |||
| <File Include="@(LibrariesRuntimeFiles)" TargetPath="framework" /> | |||
| <!-- exclude shared libs as we only need static ones --> | |||
| <LibPackageExcludes Include="framework\%2A%2A\%2A$(LibSuffix)"/> | |||
| <LibPackageExcludes Include="framework\%2A%2A\%2ANative$(LibSuffix)"/> | |||
There was a problem hiding this comment.
going to merge this to unblock the build but I think checking IsNative would be better, like we do here:
There was a problem hiding this comment.
Turned out to be much cleaner #109683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#109253 (comment)