[cdac] PrecodeStubs and CDacMetadata contracts #109030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move PrecodeStubs to a separate contract * remove instance field initialization from PrecodeMachineDescriptor * PrecodeMachineDescriptor::Init() will initialize g_PrecodeMachineDescriptor * fix thumb flag logic * add FixupPrecodeData * checkpoint: StubPrecodeData, StubCodePageSize * checkpoint: PrecodeMachineDescriptor and KnownPrecodeType
dotnet-issue-labeler
bot
added
the
needs-area-label
lambdageek
added
area-Diagnostics-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @tommcdon |
This was referenced Oct 17, 2024
lambdageek
commented
Oct 21, 2024
lambdageek
changed the title
This was referenced Oct 21, 2024
Open
|
Could I get one more look |
elinor-fung
reviewed
Oct 22, 2024
...ed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/PrecodeStubs_1.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Elinor Fung <[email protected]>
elinor-fung
reviewed
Oct 23, 2024
elinor-fung
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
PrecodeStubscontract for working with precode.Adds a
CDacMetadatacontract for exposing useful platform-specific propertiesContributes to #99302
Contributes to #108553