-
Notifications
You must be signed in to change notification settings - Fork 5k
[cdac] Make cDAC delegate to the DAC instead of the other way around #108772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @tommcdon |
lambdageek
reviewed
Oct 11, 2024
lambdageek
approved these changes
Oct 11, 2024
AaronRobinsonMSFT
approved these changes
Oct 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at handling/implementing
IXCLRData*
interfaces in cDAC, I realized we could do one of:Since we eventually want to make legacy DAC stop delegating to cDAC anyways, this seemed like a good point to start moving to (3) - before we started doing the
IXCLRData*
APIs. With this change:SOSDacImpl
in cDAC implements all the interfaces implemented byClrDataAccess
CLRDataCreateInstance
returns cDAC if it is enabledcdac_reader_get_sos_interface
takes the legacy DAC implementationISOSDac*
implementationsBehavioural differences of note:
ClrDataAccess
lifetime is handled by cDAC (when enabled), so actual release is dependent on finalization of the COM object.I ran the SOS tests in diagnostics repo against this change locally both with and without the cDAC enabled.
Contributes to #99302, #108553
cc @AaronRobinsonMSFT @davidwrighton