Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Fix compilation on ARM64 hosts #107921

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[release/8.0] Fix compilation on ARM64 hosts #107921

merged 1 commit into from
Sep 19, 2024
+31 −19

Conversation

eiriktsarpalis
Copy link
Member

Backports #104792, #104763, and #104695 to release/8.0 so that the product can be compiled on ARM64 hosts.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 17, 2024
@eiriktsarpalis eiriktsarpalis changed the title Fix compilation on ARM64 hosts [release/8.0] Fix compilation on ARM64 hosts Sep 17, 2024
@eiriktsarpalis eiriktsarpalis added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 17, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Sep 17, 2024
Open
3 tasks
@carlossanlop
Copy link
Member

Please target the release/8.0-staging branch.

@eiriktsarpalis eiriktsarpalis changed the base branch from release/8.0 to release/8.0-staging September 17, 2024 16:56
@eiriktsarpalis eiriktsarpalis marked this pull request as ready for review September 17, 2024 18:14
@teo-tsirpanis teo-tsirpanis added this to the 8.0.x milestone Sep 17, 2024
@eiriktsarpalis eiriktsarpalis added the Servicing-consider Issue for next servicing release review label Sep 18, 2024
jeffschwMSFT
jeffschwMSFT approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can take this as tell mode

cc @carlossanlop

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 19, 2024
@jeffschwMSFT jeffschwMSFT modified the milestones: 8.0.x, 8.0.11 Sep 19, 2024
@jeffschwMSFT jeffschwMSFT merged commit 03eaee3 into dotnet:release/8.0-staging Sep 19, 2024
177 of 179 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@jkotas jkotas jkotas approved these changes

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
Runtime Infra
Status: Done
Milestone
8.0.11
Development

Successfully merging this pull request may close these issues.
5 participants
@eiriktsarpalis @carlossanlop @jkotas @jeffschwMSFT @teo-tsirpanis