Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdac] break up cdacreader into 4 separate assemblies #107709

Closed
wants to merge 89 commits into from
Closed

[cdac] break up cdacreader into 4 separate assemblies #107709

wants to merge 89 commits into from

Commits on Aug 19, 2024

  1. wip: NativeCodePointers and MethodDesc CodeData

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    601938d View commit details
    Browse the repository at this point in the history

  2. checkpoint: PrecodeMachineDescriptor and KnownPrecodeType

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5f3599c View commit details
    Browse the repository at this point in the history

  3. checkpoint: StubPrecodeData, StubCodePageSize

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2cf8fd4 View commit details
    Browse the repository at this point in the history

  4. GetTemporaryEntryPointIfExists

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7ef9016 View commit details
    Browse the repository at this point in the history

  5. wip GetMethodEntryPointIfExists

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9cf7a7a View commit details
    Browse the repository at this point in the history

  6. add contract

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2d1e34e View commit details
    Browse the repository at this point in the history

  7. add missing descriptor fields

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2d4252a View commit details
    Browse the repository at this point in the history

  8. fix data descriptor reads

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c83ad25 View commit details
    Browse the repository at this point in the history

  9. add FixupPrecodeData

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c6dae6f View commit details
    Browse the repository at this point in the history

  10. add size of MethodDesc

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    43e1748 View commit details
    Browse the repository at this point in the history

  11. fix thumb flag logic

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    72369e3 View commit details
    Browse the repository at this point in the history

  12. WIP - broken - ExecutionManagerGetCodeMethodDesc

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    93f0a3d View commit details
    Browse the repository at this point in the history

  13. fix build

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    58aa614 View commit details
    Browse the repository at this point in the history

  14. fixup cdac_offsets<> -> cdac_data<>

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4c211d4 View commit details
    Browse the repository at this point in the history

  15. WIP RangeSectionMap

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ce772d9 View commit details
    Browse the repository at this point in the history

  16. tag ExecutionManager pointers

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    891f07f View commit details
    Browse the repository at this point in the history

  17. Add IJitManager::JitManagerKind

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5717664 View commit details
    Browse the repository at this point in the history

  18. WIP JitCodeToMethodInfo

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1eeb513 View commit details
    Browse the repository at this point in the history

  19. WIP NibbleMap

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2a95bda View commit details
    Browse the repository at this point in the history

  20. add HeapList

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ebf76a3 View commit details
    Browse the repository at this point in the history

  21. fix datadescriptor.h typo

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7defaef View commit details
    Browse the repository at this point in the history

  22. Add StoredSigMethodDesc

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9181f3f View commit details
    Browse the repository at this point in the history

  23. fix bit twiddling

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    86954df View commit details
    Browse the repository at this point in the history

  24. fixup NonValidated.MethodDesc.NativeCodeSlotIndex

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0d0b592 View commit details
    Browse the repository at this point in the history

  25. fixup additional pointers packing index

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    63e0334 View commit details
    Browse the repository at this point in the history

  26. fix logic typo

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c177e4d View commit details
    Browse the repository at this point in the history

  27. checkpoint: jitted methods validate

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3956b06 View commit details
    Browse the repository at this point in the history

  28. more asserts in legacy GetMethodDescData

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0b91b85 View commit details
    Browse the repository at this point in the history

  29. WIP: native code version

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d3a8bb0 View commit details
    Browse the repository at this point in the history

  30. WIP: native code version

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5fcdc60 View commit details
    Browse the repository at this point in the history

  31. checkpoint start adding NativeCodeVersion operations

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    efad4ea View commit details
    Browse the repository at this point in the history

  32. checkpoint: NativeCodeVersionContract.GetSpecificNativeCodeVersion

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    6febf72 View commit details
    Browse the repository at this point in the history

  33. remove AppDomain.CodeVersionManager from cdac 

    CodeVersionManager is basically a static class in the C++ side
    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    dd86095 View commit details
    Browse the repository at this point in the history

  34. WIP: il code version lookup table

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5b33737 View commit details
    Browse the repository at this point in the history

  35. fixup build

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    de58ab5 View commit details
    Browse the repository at this point in the history

  36. wip: FindActiveILCodeVersion/FindActiveNativeCodeVersion 

    TODO: Loader GetModuleLookupTableElement
    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0b6f6e4 View commit details
    Browse the repository at this point in the history

  37. implement GetModuleLookupMapElement

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    502cd31 View commit details
    Browse the repository at this point in the history

  38. FindActiveILCodeVersion

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    312f2ce View commit details
    Browse the repository at this point in the history

  39. checkpoint sketch out one working path through GetMethodDescData 

    lots of TODOs leftover
    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c813a78 View commit details
    Browse the repository at this point in the history

  40. fixup after rebase

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f225adb View commit details
    Browse the repository at this point in the history

  41. fixup rebae; remove duplicate global

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2cb8e86 View commit details
    Browse the repository at this point in the history

  42. checkpoint: works on some methods (NO REJIT) 

    We're straight up returning incorrect info for cJittedRejitVersions and rejitDataCurrent and rejitDataRequested

also it only works for jitted methods, not R2R
    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f4852d2 View commit details
    Browse the repository at this point in the history

  43. remove JitManagerKind in the runtime 

    the presence of RangeSection.R2RModule is a discriminator for whether we're looking at EE code or R2R code
    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    da7065e View commit details
    Browse the repository at this point in the history

  44. remove more

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    818c21c View commit details
    Browse the repository at this point in the history

  45. whitespace and comments

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1f6a909 View commit details
    Browse the repository at this point in the history

  46. remove instance field initialization from PrecodeMachineDescriptor 

    PrecodeMachineDescriptor::Init() will initialize g_PrecodeMachineDescriptor
    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    04f41f6 View commit details
    Browse the repository at this point in the history

  47. suggestion from code review make m_IsCollectible a const BYTE

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    abf9df0 View commit details
    Browse the repository at this point in the history

  48. fixup

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    71dee34 View commit details
    Browse the repository at this point in the history

  49. Revert "fixup" 

    This reverts commit bc45c00.
    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2fbc89e View commit details
    Browse the repository at this point in the history

  50. Revert "suggestion from code review make m_IsCollectible a const BYTE" 

    This reverts commit b1c7c36.
    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2e3b938 View commit details
    Browse the repository at this point in the history

  51. move PrecodeStubs to a separate contract

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1776abe View commit details
    Browse the repository at this point in the history

  52. ExecutionManager contract

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    099b5fa View commit details
    Browse the repository at this point in the history

  53. rename contract NativeCodePointers => CodeVersions

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    50046b8 View commit details
    Browse the repository at this point in the history

  54. ReJIT contract

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e2d637b View commit details
    Browse the repository at this point in the history

  55. formatting, comments and whitespace

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7724fa8 View commit details
    Browse the repository at this point in the history

  56. cleanup

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a53b3ae View commit details
    Browse the repository at this point in the history

  57. "NDirect" -> "PInvoke" in descriptor and contracts

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    124ee6a View commit details
    Browse the repository at this point in the history

  58. WIP: contract writeups

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    fb1676b View commit details
    Browse the repository at this point in the history

  59. fix build

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f1d757e View commit details
    Browse the repository at this point in the history

  60. placeholder ExecutionManager contract

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f1d7be8 View commit details
    Browse the repository at this point in the history

  61. placeholder ExecutionManager contract; updates to RTS and Loader

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ebb4a67 View commit details
    Browse the repository at this point in the history

  62. refactor ExecutionManager

    @lambdageek
    lambdageek committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    aac3faf View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. remove dead method from contract

    @lambdageek
    lambdageek committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ef51f0e View commit details
    Browse the repository at this point in the history

  2. fix typo

    @lambdageek
    lambdageek committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    92764a2 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr

    @lambdageek
    lambdageek committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4e1a620 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Apply suggestions from code review

    @lambdageek
    lambdageek committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    037c349 View commit details
    Browse the repository at this point in the history

  2. Add PrecodeStubs contract writeup

    @lambdageek
    lambdageek committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    25d8343 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr

    @lambdageek
    lambdageek committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ac0165a View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge remote-tracking branch 'origin/main' into cdac-nativecodeptr

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8f5e98b View commit details
    Browse the repository at this point in the history

  2. checkpoint: Abstractions

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    81fe51b View commit details
    Browse the repository at this point in the history

  3. checkpoint begin moving contracts to Abstractions

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c376c4c View commit details
    Browse the repository at this point in the history

  4. rationalize IContractFactory

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9c3f010 View commit details
    Browse the repository at this point in the history

  5. move IObject contract

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7ec2f79 View commit details
    Browse the repository at this point in the history

  6. fixup interfaces

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    efaff82 View commit details
    Browse the repository at this point in the history

  7. move IRuntimeTypeSystem contract

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c8b5c3f View commit details
    Browse the repository at this point in the history

  8. move IException contract

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e69d73c View commit details
    Browse the repository at this point in the history

  9. move ILoader contract

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6861830 View commit details
    Browse the repository at this point in the history

  10. move IEcmaMetadata contract

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    14a7ac6 View commit details
    Browse the repository at this point in the history

  11. move IDacStreams

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1caf9de View commit details
    Browse the repository at this point in the history

  12. move IThread contract

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    79d6834 View commit details
    Browse the repository at this point in the history

  13. move IExecutionManager, IPrecodeStubs, IReJIT contracts

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e9fd58b View commit details
    Browse the repository at this point in the history

  14. simplify IContractFactory; make factories into classes

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bcb9eac View commit details
    Browse the repository at this point in the history

  15. rewrite all contract impls in terms of ITarget

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f2844ae View commit details
    Browse the repository at this point in the history

  16. copy some docstrings

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a36919b View commit details
    Browse the repository at this point in the history

  17. remove downcasts ITarget -> Target

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8f5fcb6 View commit details
    Browse the repository at this point in the history

  18. make TypeInfo and FieldInfo readonly

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    69f134a View commit details
    Browse the repository at this point in the history

  19. move contracts and data to a Contracts assembly

    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9aec4dd View commit details
    Browse the repository at this point in the history

  20. make IContractFactory.CreateContract non-static 

    make Registry hold a collection of contract factories, optionally with a configure callback
    @lambdageek
    lambdageek committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    dd75ae8 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Add a TestPlaceholderTarget : ITarget

    @lambdageek
    lambdageek committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    222c2db View commit details
    Browse the repository at this point in the history