Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NRBF] Arrays of any records #107627

Closed
wants to merge 5 commits into from

Conversation

adamsitnik
Copy link
Member

new IEnumerable[1] { "hello" } is represented as an binary array of system classes. There were two bugs:

  • I was assuming that strings can be contained only by arrays of strings and arrays of objects.
  • I was assuming that every array that is not an array of primitive type or array, is an array of ClassRecord. I was wrong.

For now it's just a DRAFT as I need to think a little bit more about it.

@adamsitnik
Copy link
Member Author

@MihuBot fuzz NrbfDecoder

# Conflicts:
#	src/libraries/System.Formats.Nrbf/src/System/Formats/Nrbf/RectangularArrayRecord.cs
@adamsitnik
Copy link
Member Author

@MihuBot fuzz NrbfDecoder

@adamsitnik
Copy link
Member Author

I need to think more of it, closing for now.

@adamsitnik adamsitnik closed this Sep 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant