Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable MemoryStream_SeekOverflow_Throws on Linux #107163

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Disable MemoryStream_SeekOverflow_Throws on Linux #107163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Runtime/tests/System.IO.Tests/MemoryStream/MemoryStreamTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ from bufferContext in
[MemberData(nameof(MemoryStream_PositionOverflow_Throws_MemberData))]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "https://github.com/dotnet/runtime/issues/92467")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/100225", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.IsX64Process))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/100558", TestPlatforms.Linux)]
Comment on lines 106 to +107
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to have more than one ActiveIssue.

The previous ActiveIssue deactivated the test in mono, windows, x64.

The current ActiveIssue is deactivating the test in all runtimes, in all architectures, but only in Linux. Isn't it also affecting Windows coreclr?

I think we should deactivate this test for everything. No platform filters. That way we can be 100% sure if the error code 137 is being caused by this test or not. If we deactivate this for only a few platforms, we may still see hits and won't know for sure if this was the cause.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it also affecting Windows coreclr?

I sampled the errors in the Report table, and all seem to be a Linux flavor using CoreCLR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failures for the tracking issue will always be for Linux because the 137 exit code in the error message pattern is a Linux behavior.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mkay. Approving!

public void MemoryStream_SeekOverflow_Throws(SeekMode mode, int bufferSize, int origin)
{
byte[] buffer = new byte[bufferSize];
Expand Down