-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target .NET 10 / net10.0 #106599
base: main
Are you sure you want to change the base?
Target .NET 10 / net10.0 #106599
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
to be able to build System.Text.Json on net9.0.
...libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj
Show resolved
Hide resolved
@ViktorHofer I already had this PR open for this purpose: #106421 |
dotnet/sdk#43070 has the sdk first work |
This looks in pretty good shape now, @ilonatommy can you take a look at why the perf lanes and http functional tests are failing? |
This might fix the perf leg: dotnet/performance#4470. You can quickly try it, to find out if there is more work to be done, by temporarily switching to my branch: --- a/eng/pipelines/coreclr/templates/build-perf-bdn-app.yml
+++ b/eng/pipelines/coreclr/templates/build-perf-bdn-app.yml
@@ -70,7 +70,7 @@ steps:
- script: |
set -x
pwd
- git clone https://github.com/dotnet/performance.git --depth 1 -b ${{parameters.perfBranch}} --single-branch
+ git clone https://github.com/am11/performance.git --depth 1 -b patch-1 --single-branch
displayName: Clone performance
workingDirectory: $(Build.SourcesDirectory) |
Http functional tests are not from this PR: #108019. Will update about perf when I have more info. |
Pushed another change, could you please rerun (just) that leg? |
Strange that it's neither finding startswith("9.0") nor startswith("10.0") subdir. Added some diagnostics to see which SDKs are available. One more try. :) |
Sorry it was a wrong pipeline, this is the correct one: --- a/eng/pipelines/runtime-wasm-perf.yml
+++ b/eng/pipelines/runtime-wasm-perf.yml
@@ -32,9 +32,9 @@ extends:
runProfile: 'v8'
collectHelixLogsScript: ${{ variables._wasmCollectHelixLogsScript }}
onlySanityCheck: true
- #perfForkToUse: # dummy change
- #url: https://github.com/radical/performance
- #branch: fix-build
+ perfForkToUse: # dummy change
+ url: https://github.com/am11/performance
+ branch: patch-1
#downloadSpecificBuild:
#buildId: '1878694'
#pipeline: 'perf-wasm' |
Contributes to #105343