Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target .NET 10 / net10.0 #106599

Draft
wants to merge 64 commits into
base: main
Choose a base branch
from
Draft

Conversation

ViktorHofer
Copy link
Member

Contributes to #105343

@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Aug 18, 2024
@dotnet dotnet deleted a comment from dotnet-issue-labeler bot Aug 18, 2024
@dotnet dotnet deleted a comment from dotnet-issue-labeler bot Aug 18, 2024
@lewing lewing added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 19, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Member

@ViktorHofer I already had this PR open for this purpose: #106421

@lewing
Copy link
Member

lewing commented Sep 16, 2024

dotnet/sdk#43070 has the sdk first work

@lewing
Copy link
Member

lewing commented Sep 20, 2024

This looks in pretty good shape now, @ilonatommy can you take a look at why the perf lanes and http functional tests are failing?

@am11
Copy link
Member

am11 commented Sep 20, 2024

This might fix the perf leg: dotnet/performance#4470. You can quickly try it, to find out if there is more work to be done, by temporarily switching to my branch:

--- a/eng/pipelines/coreclr/templates/build-perf-bdn-app.yml
+++ b/eng/pipelines/coreclr/templates/build-perf-bdn-app.yml
@@ -70,7 +70,7 @@ steps:
   - script: |
       set -x
       pwd
-      git clone https://github.com/dotnet/performance.git --depth 1 -b ${{parameters.perfBranch}} --single-branch
+      git clone https://github.com/am11/performance.git --depth 1 -b patch-1 --single-branch
     displayName:  Clone performance
     workingDirectory: $(Build.SourcesDirectory)

@ilonatommy
Copy link
Member

ilonatommy commented Sep 20, 2024

This looks in pretty good shape now, @ilonatommy can you take a look at why the perf lanes and http functional tests are failing?

Http functional tests are not from this PR: #108019. Will update about perf when I have more info.
{61837F44-D445-463E-B7B5-847834B540D8}

@ilonatommy
Copy link
Member

@am11, branch with parsing fix did not help, build.

@am11
Copy link
Member

am11 commented Sep 20, 2024

Pushed another change, could you please rerun (just) that leg?

@am11
Copy link
Member

am11 commented Sep 20, 2024

Strange that it's neither finding startswith("9.0") nor startswith("10.0") subdir. Added some diagnostics to see which SDKs are available. One more try. :)

@am11
Copy link
Member

am11 commented Sep 20, 2024

Sorry it was a wrong pipeline, this is the correct one:

--- a/eng/pipelines/runtime-wasm-perf.yml
+++ b/eng/pipelines/runtime-wasm-perf.yml
@@ -32,9 +32,9 @@ extends:
           runProfile: 'v8'
           collectHelixLogsScript: ${{ variables._wasmCollectHelixLogsScript }}
           onlySanityCheck: true
-          #perfForkToUse: # dummy change
-            #url: https://github.com/radical/performance
-            #branch: fix-build
+          perfForkToUse: # dummy change
+            url: https://github.com/am11/performance
+            branch: patch-1
           #downloadSpecificBuild:
             #buildId: '1878694'
             #pipeline: 'perf-wasm'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

10 participants