JIT: Handle GT_SWIFT_ERROR_RET in LinearScan::getKillSetForNode #102519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
/azp run runtime-coreclr jitstress-random |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced May 22, 2024
|
/ba-g Linux x64 timeouts are blocking clean CI |
steveharter
pushed a commit
to steveharter/runtime
that referenced
this pull request
May 28, 2024
…2519) Fixes dotnet#102349. In LinearScan::getKillSetForNode, GT_SWIFT_ERROR_RET (which represents the regular return value, alongside the Swift error register value to be loaded) needs to be handled like GT_RETURN if Compiler::compIsProfilerHookNeeded is true, which is possible under some JitStress scenarios.
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…2519) Fixes dotnet#102349. In LinearScan::getKillSetForNode, GT_SWIFT_ERROR_RET (which represents the regular return value, alongside the Swift error register value to be loaded) needs to be handled like GT_RETURN if Compiler::compIsProfilerHookNeeded is true, which is possible under some JitStress scenarios.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102349. In
LinearScan::getKillSetForNode,GT_SWIFT_ERROR_RET(which represents the regular return value, alongside the Swift error register value to be loaded) needs to be handled likeGT_RETURNifCompiler::compIsProfilerHookNeededis true, which is possible under some JitStress scenarios.This failure was found by
runtime-coreclr jitstress-randomsettingDOTNET_JitStress=da-- I'm not sure how (or if) I can force CI to use the same env to verify correctness...cc @dotnet/jit-contrib