Skip to content

Updating some packages versions. #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Updating some packages versions. #703

merged 2 commits into from
Jul 29, 2019

Conversation

jorive
Copy link
Member

@jorive jorive commented Jul 25, 2019

No description provided.

@jorive jorive requested review from billwert and adamsitnik July 25, 2019 16:36
@billwert
Copy link
Member

@adamsitnik has been working on a BDN update for a while in #138 and we've hit some weirdness with it. Any update Adam?

@jorive
Copy link
Member Author

jorive commented Jul 29, 2019

ping

@adamsitnik
Copy link
Member

Updating BenchmarkDotNet to a newer version has a dedicated PR - #511. @billwert I am going to update the status of #511 in #511.

@jorive in the meantime, could you please revert the BDN version update here? otherwise than that, other updates are ok

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@billwert
Copy link
Member

Sorry I got the wrong number. :)

@jorive jorive merged commit 7c8087a into dotnet:master Jul 29, 2019
@jorive jorive deleted the dev/versions branch July 29, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants