Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ITargetHolder methods non-generic to avoid costly lookup at runtime #9168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Make ITargetHolder methods non-generic to avoid costly lookup at runtime

335e341
Select commit
Loading
Failed to load commit list.
Open

Make ITargetHolder methods non-generic to avoid costly lookup at runtime #9168

Make ITargetHolder methods non-generic to avoid costly lookup at runtime
335e341
Select commit
Loading
Failed to load commit list.
Azure Pipelines / dotnet.orleans failed Oct 9, 2024 in 38m 59s

Build #20241009.1 had test failures

Details

Tests

  • Failed: 126 (2.39%)
  • Passed: 4,277 (81.08%)
  • Other: 872 (16.53%)
  • Total: 5,275

Annotations

Check failure on line 3178 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet.orleans

Build log #L3178

Error: The process 'C:\hostedtoolcache\windows\dotnet\dotnet.exe' failed with exit code 1

Check failure on line 3181 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet.orleans

Build log #L3181

Dotnet command failed with non-zero exit code on the following projects : [ '' ]

Check failure on line 253 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet.orleans

Build log #L253

Error: The process 'C:\hostedtoolcache\windows\dotnet\dotnet.exe' failed with exit code 1

Check failure on line 256 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet.orleans

Build log #L256

Dotnet command failed with non-zero exit code on the following projects : [ '' ]

Check failure on line 1 in DefaultCluster.Tests.AsyncEnumerableGrainCallTests.ObservableGrain_AsyncEnumerable

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet.orleans

DefaultCluster.Tests.AsyncEnumerableGrainCallTests.ObservableGrain_AsyncEnumerable

System.ArgumentException : Cannot override a component which is implemented by this grain
Raw output
   at Orleans.Runtime.ActivationData.SetComponent[TComponent](TComponent instance) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 282
   at Orleans.Runtime.ActivationData.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 267
   at Orleans.Runtime.ActivationData.Orleans.Serialization.Invocation.ITargetHolder.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 233
   at Orleans.Runtime.TargetHolderExtensions.GetComponent[TComponent](ITargetHolder targetHolder) in /_/src/Orleans.Serialization/Invocation/TargetHolderExtensions.cs:line 22
   at Orleans.Runtime.AsyncEnumerableGrainExtension..ctor(IGrainContext grainContext, IOptions`1 messagingOptions) in /_/src/Orleans.Core/Runtime/AsyncEnumerableGrainExtension.cs:line 35
   at InvokeStub_AsyncEnumerableGrainExtension..ctor(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitCache(ServiceCallSite callSite, RuntimeResolverContext context, ServiceProviderEngineScope serviceProviderEngine, RuntimeResolverLock lockType)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScopeCache(ServiceCallSite callSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.<>c__DisplayClass2_0.<RealizeService>b__0(ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.GetService(Type serviceType)
   at Orleans.Runtime.ActivationData.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 265
   at Orleans.Runtime.ActivationData.Orleans.Serialization.Invocation.ITargetHolder.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 233
   at OrleansCodeGen.Orleans.Runtime.Invokable_IAsyncEnumerableGrainExtension_GrainReference_Ext_370CD5AB_1`1.SetTarget(ITargetHolder holder) in /_/src/Orleans.Core.Abstractions/Orleans.CodeGenerator/Orleans.CodeGenerator.OrleansSerializationSourceGenerator/Orleans.Core.Abstractions.orleans.g.cs:line 97
   at Orleans.Runtime.InsideRuntimeClient.Invoke(IGrainContext target, Message message) in /_/src/Orleans.Runtime/Core/InsideRuntimeClient.cs:line 262
--- End of stack trace from previous location ---
   at Orleans.Serialization.Invocation.ResponseCompletionSource`1.GetResult(Int16 token) in /_/src/Orleans.Serialization/Invocation/ResponseCompletionSource.cs:line 230
   at Orleans.Runtime.AsyncEnumeratorProxy`1.MoveNextAsync() in /_/src/Orleans.Core.Abstractions/Runtime/AsyncEnumerableRequest.cs:line 249
   at DefaultCluster.Tests.AsyncEnumerableGrainCallTests.ObservableGrain_AsyncEnumerable() in /_/test/DefaultCluster.Tests/AsyncEnumerableGrainCallTests.cs:line 36
   at DefaultCluster.Tests.AsyncEnumerableGrainCallTests.Obse

Check failure on line 1 in DefaultCluster.Tests.ProviderTests.Providers_AutoInstallExtensionTest

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet.orleans

DefaultCluster.Tests.ProviderTests.Providers_AutoInstallExtensionTest

System.ArgumentException : Cannot override a component which is implemented by this grain context
Raw output
   at Orleans.Runtime.ActivationData.SetComponent[TComponent](TComponent instance) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 287
   at Orleans.Runtime.ActivationData.Orleans.Serialization.Invocation.ITargetHolder.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 242
   at OrleansCodeGen.UnitTests.GrainInterfaces.Invokable_IAutoExtension_GrainReference_Ext_9671CDE8.SetTarget(ITargetHolder holder) in /_/test/Grains/TestGrainInterfaces/Orleans.CodeGenerator/Orleans.CodeGenerator.OrleansSerializationSourceGenerator/TestGrainInterfaces.orleans.g.cs:line 34643
   at Orleans.Runtime.InsideRuntimeClient.Invoke(IGrainContext target, Message message) in /_/src/Orleans.Runtime/Core/InsideRuntimeClient.cs:line 262
--- End of stack trace from previous location ---
   at Orleans.Serialization.Invocation.ResponseCompletionSource`1.GetResult(Int16 token) in /_/src/Orleans.Serialization/Invocation/ResponseCompletionSource.cs:line 230
   at System.Threading.Tasks.ValueTask`1.ValueTaskSourceAsTask.<>c.<.cctor>b__4_0(Object state)
--- End of stack trace from previous location ---
   at DefaultCluster.Tests.ProviderTests.Providers_AutoInstallExtensionTest() in /_/test/DefaultCluster.Tests/ProviderTests.cs:line 141
--- End of stack trace from previous location ---

Check failure on line 1 in DefaultCluster.Tests.AsyncEnumerableGrainCallTests.ObservableGrain_AsyncEnumerable_NoBatching

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet.orleans

DefaultCluster.Tests.AsyncEnumerableGrainCallTests.ObservableGrain_AsyncEnumerable_NoBatching

System.ArgumentException : Cannot override a component which is implemented by this grain
Raw output
   at Orleans.Runtime.ActivationData.SetComponent[TComponent](TComponent instance) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 282
   at Orleans.Runtime.ActivationData.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 267
   at Orleans.Runtime.ActivationData.Orleans.Serialization.Invocation.ITargetHolder.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 233
   at Orleans.Runtime.TargetHolderExtensions.GetComponent[TComponent](ITargetHolder targetHolder) in /_/src/Orleans.Serialization/Invocation/TargetHolderExtensions.cs:line 22
   at Orleans.Runtime.AsyncEnumerableGrainExtension..ctor(IGrainContext grainContext, IOptions`1 messagingOptions) in /_/src/Orleans.Core/Runtime/AsyncEnumerableGrainExtension.cs:line 35
   at InvokeStub_AsyncEnumerableGrainExtension..ctor(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitCache(ServiceCallSite callSite, RuntimeResolverContext context, ServiceProviderEngineScope serviceProviderEngine, RuntimeResolverLock lockType)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScopeCache(ServiceCallSite callSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.<>c__DisplayClass2_0.<RealizeService>b__0(ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.GetService(Type serviceType)
   at Orleans.Runtime.ActivationData.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 265
   at Orleans.Runtime.ActivationData.Orleans.Serialization.Invocation.ITargetHolder.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 233
   at OrleansCodeGen.Orleans.Runtime.Invokable_IAsyncEnumerableGrainExtension_GrainReference_Ext_370CD5AB_1`1.SetTarget(ITargetHolder holder) in /_/src/Orleans.Core.Abstractions/Orleans.CodeGenerator/Orleans.CodeGenerator.OrleansSerializationSourceGenerator/Orleans.Core.Abstractions.orleans.g.cs:line 97
   at Orleans.Runtime.InsideRuntimeClient.Invoke(IGrainContext target, Message message) in /_/src/Orleans.Runtime/Core/InsideRuntimeClient.cs:line 262
--- End of stack trace from previous location ---
   at Orleans.Serialization.Invocation.ResponseCompletionSource`1.GetResult(Int16 token) in /_/src/Orleans.Serialization/Invocation/ResponseCompletionSource.cs:line 230
   at Orleans.Runtime.AsyncEnumeratorProxy`1.MoveNextAsync() in /_/src/Orleans.Core.Abstractions/Runtime/AsyncEnumerableRequest.cs:line 249
   at DefaultCluster.Tests.AsyncEnumerableGrainCallTests.ObservableGrain_AsyncEnumerable_NoBatching() in /_/test/DefaultCluster.Tests/AsyncEnumerableGrainCallTests.cs:line 124
   at DefaultCluster.Tests.AsyncEnumerableGrainCa

Check failure on line 1 in DefaultCluster.Tests.AsyncEnumerableGrainCallTests.ObservableGrain_AsyncEnumerable_SplitBatch

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dotnet.orleans

DefaultCluster.Tests.AsyncEnumerableGrainCallTests.ObservableGrain_AsyncEnumerable_SplitBatch

System.ArgumentException : Cannot override a component which is implemented by this grain
Raw output
   at Orleans.Runtime.ActivationData.SetComponent[TComponent](TComponent instance) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 282
   at Orleans.Runtime.ActivationData.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 267
   at Orleans.Runtime.ActivationData.Orleans.Serialization.Invocation.ITargetHolder.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 233
   at Orleans.Runtime.TargetHolderExtensions.GetComponent[TComponent](ITargetHolder targetHolder) in /_/src/Orleans.Serialization/Invocation/TargetHolderExtensions.cs:line 22
   at Orleans.Runtime.AsyncEnumerableGrainExtension..ctor(IGrainContext grainContext, IOptions`1 messagingOptions) in /_/src/Orleans.Core/Runtime/AsyncEnumerableGrainExtension.cs:line 35
   at InvokeStub_AsyncEnumerableGrainExtension..ctor(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitCache(ServiceCallSite callSite, RuntimeResolverContext context, ServiceProviderEngineScope serviceProviderEngine, RuntimeResolverLock lockType)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScopeCache(ServiceCallSite callSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.<>c__DisplayClass2_0.<RealizeService>b__0(ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.GetService(Type serviceType)
   at Orleans.Runtime.ActivationData.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 265
   at Orleans.Runtime.ActivationData.Orleans.Serialization.Invocation.ITargetHolder.GetComponent(Type componentType) in /_/src/Orleans.Runtime/Catalog/ActivationData.cs:line 233
   at OrleansCodeGen.Orleans.Runtime.Invokable_IAsyncEnumerableGrainExtension_GrainReference_Ext_370CD5AB_1`1.SetTarget(ITargetHolder holder) in /_/src/Orleans.Core.Abstractions/Orleans.CodeGenerator/Orleans.CodeGenerator.OrleansSerializationSourceGenerator/Orleans.Core.Abstractions.orleans.g.cs:line 97
   at Orleans.Runtime.InsideRuntimeClient.Invoke(IGrainContext target, Message message) in /_/src/Orleans.Runtime/Core/InsideRuntimeClient.cs:line 262
--- End of stack trace from previous location ---
   at Orleans.Serialization.Invocation.ResponseCompletionSource`1.GetResult(Int16 token) in /_/src/Orleans.Serialization/Invocation/ResponseCompletionSource.cs:line 230
   at Orleans.Runtime.AsyncEnumeratorProxy`1.MoveNextAsync() in /_/src/Orleans.Core.Abstractions/Runtime/AsyncEnumerableRequest.cs:line 249
   at DefaultCluster.Tests.AsyncEnumerableGrainCallTests.ObservableGrain_AsyncEnumerable_SplitBatch() in /_/test/DefaultCluster.Tests/AsyncEnumerableGrainCallTests.cs:line 93
   at DefaultCluster.Tests.AsyncEnumerableGrainCal