Support MessagePack union types #9151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wassim-k
commented
Sep 26, 2024
| @@ -198,7 +200,7 @@ object IDeepCopier.DeepCopy(object input, CopyContext context) | |||
| var sequence = bufferWriter.Value.AsReadOnlySequence(); | |||
| result = MessagePackSerializer.Deserialize(input.GetType(), sequence, _options.SerializerOptions); | |||
| } | |||
| catch | |||
| finally | |||
There was a problem hiding this comment.
Potential memory leak
wassim-k
commented
Sep 26, 2024
|
@dotnet-policy-service agree |
wassim-k
force-pushed
the
feature/message-pack-union-types
branch
from
a2ee56f
to
6897e74
Compare
ReubenBond
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of MessagePackCodec doesn't support Grain methods where a parameter is an interface that is marked as a message pack union type.
Microsoft Reviewers: Open in CodeFlow