Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IClusterConnectionStatusObserver support #9145

Merged

Conversation

galvesribeiro
Copy link
Member

@galvesribeiro galvesribeiro commented Sep 23, 2024

This PR adds IClusterConnectionStatusObserver.

This interface allow clients to be notified when the client loses or regain connectivity to the cluster. Similar to GatewayCountChangedHandler and ConnectionToClusterLostHandler delegates.

Also helper methods were added to ClientBuilderExtensions to the new interface and also the delegate registration.

Microsoft Reviewers: Open in CodeFlow

@ReubenBond
Copy link
Member

@galvesribeiro could you grant me push access to this branch? I believe there's an option on the right side of this page.

@ReubenBond ReubenBond force-pushed the feat/client-connection-status-observer branch from 37eb54a to cc7050e Compare September 30, 2024 22:39
@ReubenBond ReubenBond force-pushed the feat/client-connection-status-observer branch from cc7050e to 20ddea4 Compare September 30, 2024 22:40
@ReubenBond ReubenBond merged commit 546b739 into dotnet:main Oct 1, 2024
22 checks passed
@ReubenBond ReubenBond deleted the feat/client-connection-status-observer branch October 1, 2024 01:57
@ReubenBond
Copy link
Member

I needed to merge another commit before this (in-proc test cluster) - I'll revert this for now and we can merge it after

ReubenBond added a commit that referenced this pull request Oct 1, 2024
@ReubenBond ReubenBond restored the feat/client-connection-status-observer branch October 1, 2024 01:58
ReubenBond added a commit that referenced this pull request Oct 1, 2024
…TestCluster is merged (#9157)

Revert "Add IClusterConnectionStatusObserver support (#9145)"

This reverts commit 546b739.
@ReubenBond
Copy link
Member

Apologies, @galvesribeiro, could you re-open this one? You can use the same branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants