-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the Label height within VerticalStackLayout is truncated when width is set #25748
Draft
NanthiniMahalingam
wants to merge
13
commits into
dotnet:main
Choose a base branch
from
NanthiniMahalingam:issue-15559
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−0
Draft
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
55d2b1e
Fixed the label truncated issue in iOS and macOS Platform
NanthiniMahalingam a5fe9f3
Merge branch 'dotnet:main' into issue-15559
NanthiniMahalingam 6e58f31
Merge branch 'dotnet:main' into issue-15559
NanthiniMahalingam 276bcc5
Update ViewHandlerExtensions.iOS.cs
NanthiniMahalingam 784d05a
Update ViewHandlerExtensions.iOS.cs
NanthiniMahalingam b3d5c1e
Update ViewHandlerExtensions.iOS.cs
NanthiniMahalingam 92679bb
Merge branch 'dotnet:main' into issue-15559
NanthiniMahalingam 1c00ce3
Added the test case for layout and label element.
NanthiniMahalingam 63fb577
Merge branch 'dotnet:main' into issue-15559
NanthiniMahalingam d4635ea
Removed the unwanted wait for element in test case.
NanthiniMahalingam 5a3e628
Added the output images in android and iOS platform
NanthiniMahalingam ff73bfd
Merge branch 'main' of https://github.com/NanthiniMahalingam/maui int…
NanthiniMahalingam 427b141
Added the output image for windows platform.
NanthiniMahalingam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+78.2 KB
...oid.Tests/snapshots/android/LabelDisplayWithoutCroppingInsideVerticalLayout.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 17 additions & 0 deletions
17
src/Controls/tests/TestCases.HostApp/Issues/Issue15559.xaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<?xml version="1.0" encoding="utf-8" ?> | ||
<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
x:Class="Maui.Controls.Sample.Issues.Issue15559" | ||
Title="Issue15559"> | ||
|
||
<VerticalStackLayout Spacing="20" Margin="20"> | ||
|
||
<VerticalStackLayout WidthRequest="200" BackgroundColor="Yellow"> | ||
<Label Text="Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore."/> | ||
</VerticalStackLayout> | ||
|
||
<VerticalStackLayout BackgroundColor="Yellow"> | ||
<Label AutomationId="Label" WidthRequest="200" Text="Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore."/> | ||
</VerticalStackLayout> | ||
</VerticalStackLayout> | ||
</ContentPage> |
11 changes: 11 additions & 0 deletions
11
src/Controls/tests/TestCases.HostApp/Issues/Issue15559.xaml.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
namespace Maui.Controls.Sample.Issues; | ||
|
||
[Issue(IssueTracker.Github, 15559, "[iOS] Vertical layout content of label is truncated when a width request is set in the layout", PlatformAffected.iOS | PlatformAffected.macOS)] | ||
|
||
public partial class Issue15559 : ContentPage | ||
{ | ||
public Issue15559() | ||
{ | ||
InitializeComponent(); | ||
} | ||
} |
22 changes: 22 additions & 0 deletions
22
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue15559.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
using NUnit.Framework; | ||
using UITest.Appium; | ||
using UITest.Core; | ||
|
||
namespace Microsoft.Maui.TestCases.Tests.Issues | ||
{ | ||
public class Issue15559 : _IssuesUITest | ||
{ | ||
public override string Issue => "[iOS] Vertical layout content of label is truncated when a width request is set in the layout"; | ||
|
||
public Issue15559(TestDevice device) : base(device) | ||
{ } | ||
|
||
[Test] | ||
[Category(UITestCategories.Layout)] | ||
public void LabelDisplayWithoutCroppingInsideVerticalLayout() | ||
{ | ||
App.WaitForElement("Label"); | ||
VerifyScreenshot(); | ||
} | ||
} | ||
} |
Binary file added
BIN
+89.9 KB
...ses.iOS.Tests/snapshots/ios/LabelDisplayWithoutCroppingInsideVerticalLayout.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Windows snapshot is pending, already available in the latest build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz ,
Included the snapshot for the Windows platform. Could you please check and let me know?