-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] IndicatorView with DataTemplate (custom image) does not render correctly when ItemsSource change #24717
base: main
Are you sure you want to change the base?
Conversation
Hey there @NanthiniMahalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding a comment about the test and not actually reviewing the code yet.
"https://xcdn.next.co.uk/Common/Items/Default/Default/ItemImages/AltItemZoom/440022s.jpg", | ||
"https://xcdn.next.co.uk/Common/Items/Default/Default/ItemImages/AltItemZoom/440022s2.jpg", | ||
"https://xcdn.next.co.uk/Common/Items/Default/Default/ItemImages/AltItemZoom/440022s3.jpg", | ||
"https://xcdn.next.co.uk/Common/Items/Default/Default/ItemImages/AltItemZoom/440022s4.jpg", | ||
"https://xcdn.next.co.uk/Common/Items/Default/Default/ItemImages/AltItemZoom/440022s5.jpg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could these rather be a collection of images in the app, or maybe the dotnet bot multiple times. The network on CI is never reliable enough for testing. No idea why everything else will work but when you need the network for a test it stops working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will modify the collection of images in the app, or possibly use the dotnet bot image multiple times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified the collection of images in the Issue21980 view model class.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Root Cause
Description of Change
After adding the Update indicator view template in UpdatingIndcatorCount method for mapping the Count property in IndicatorViewHandler android class, indicator view data template does not mess up.
Issues Fixed
Fixes Android 21980
Output:
Android Platform
Before changes:
IndicatorView_BeforeChanges.mp4
After changes:
IndicatorView_AfterChanges.mp4