Fix TapGestureRecognizer disregards parent's IsEnabled status #22578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @BlotskiyDmitriy! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested review from
PureWeen and
mattleibow
and removed request for
jfversluis
|
Appreciate the PR, but we are going to approach this in a slightly different way. #23049 takes an approach that is more similar to how Android works, and declines to surface the touch event in the gesture manager when the control is disabled (which may fix other touch gesture related scenarios that should not fire when the control is disabled too). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When calling the IsEnabled property, the container parent is checked because it is not equal to what is in other controls.
For example. The parent of the Grid is the UIResponder, and the parent of the Button is the UIControl.
Previously, for this reason, the IsEnabled property was not changed for any container.
Issues Fixed
TapGestureRecognizer disregards parent's IsEnabled status on iOS and Catalyst.
Fixed for: layouts except frame on iOS and Catalyst.
Fixes #
#18995
Branch: main