-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS][NativeAOT] Adding NativeAOT RunOniOS device test #19923
[iOS][NativeAOT] Adding NativeAOT RunOniOS device test #19923
Conversation
Might need this to also have the AOT:
|
Thanks. I wasn't aware only @mattleibow |
@ivanpovazan I think you could do either one, but maybe merging your test into the existing You could add a |
I modified the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonathanpeppers can we merged this, or should we retry to get the CI green? |
I clicked retry one more time, we might need to |
ef8bbee
to
8ba9faf
Compare
/rebase |
8ba9faf
to
5611625
Compare
@jonathanpeppers I manually rebased and pushed, but I see it can be done with
UPDATE: CI finally passed on another retry ^ |
This PR adds an integration test for testing NativeAOT running on iOS by extending the existing `RunOniOS` test method with two new parameters: * `runtimeIdentifier` - string denoting the target runtime identifier i.e., on which platform the test will be executed. Since currently CI only runs these tests on simulators (note: referring to `iossimulator-x64` in the target path below) https://github.com/dotnet/maui/blob/f9a885219953dd67171b0986f9746795fc5fc207/src/TestUtils/src/Microsoft.Maui.IntegrationTests/AppleTemplateTests.cs#L47 We are passing the same value `iossimulator-x64` in all cases for the time being. * `runtimeVariant` - new enum type - `RuntimeVariant` differentiating runtime variants to run the test with (at the moment supported variants are `Mono` and `NativeAOT`). Contributes to #19817
Description
This PR adds an integration test for testing NativeAOT running on iOS by extending the existing
RunOniOS
test method with two new parameters:runtimeIdentifier
- string denoting the target runtime identifier i.e., on which platform the test will be executed. Since currently CI only runs these tests on simulators (note: referring toiossimulator-x64
in the target path below)maui/src/TestUtils/src/Microsoft.Maui.IntegrationTests/AppleTemplateTests.cs
Line 47 in f9a8852
iossimulator-x64
in all cases for the time being.runtimeVariant
- new enum type -RuntimeVariant
differentiating runtime variants to run the test with (at the moment supported variants areMono
andNativeAOT
).Contributes to #19817
/cc: @jonathanpeppers @simonrozsival