Allow iOS Keyboard Scrolling to be turned off in Lifecycle Events #18266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tj-devel709
added
platform/iOS 🍎
area-controls-entry
ghost
added
the
legacy-area-controls
tj-devel709
force-pushed
the
dev/TJ/KeyboardScrolling-Connect
branch
from
72e213d to
3393eb4
Compare
hartez
approved these changes
Oct 24, 2023
|
/backport to release/8.0.1xx-rc2.2 |
|
Started backporting to release/8.0.1xx-rc2.2: https://github.com/dotnet/maui/actions/runs/6631550483 |
samhouts
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-8.0.100-rc.2.9530
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The iOS Keyboard Scrolling can be turned off by customers if they would like to use custom code to control the scrolling. At this point, the Disconnect() method that turns off the scrolling has trouble when used in Lifecycle events since it would be overrided by the default Connect() method in the Lifecycle events. This change allows the user to call the Disconnect anywhere in the code and be respected. Also adds a little documentation to the Connect and Disconnect method.
This code for this fix comes from this pending PR but is in a bite-sized PR to help get in by GA :)