Skip to content

[CoreCLR] Implement mono_assembly_get_object. #11254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2021
Merged

[CoreCLR] Implement mono_assembly_get_object. #11254

merged 1 commit into from
Apr 21, 2021

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Apr 21, 2021 •
edited
Loading

Next failure is now:

monotouchtest[27142:4675921] Xamarin.Mac: The method mono_profiler_install has not been implemented for CoreCLR.

@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Apr 21, 2021
@filipnavara
Copy link
Member

The method mono_profiler_install has not been implemented for CoreCLR.

Reminds me of dotnet/designs#197 (comment)

@rolfbjarne rolfbjarne mentioned this pull request Apr 21, 2021
Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

Test results

1 tests failed, 98 tests passed.

Failed tests

  • introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): Failed

Pipeline on Agent XAMBOT-1110
Merge c69bc3d into 405441f

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2420)

@rolfbjarne rolfbjarne merged commit 320527a into dotnet:main Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rolfbjarne @filipnavara @vs-mobiletools-engineering-service2 @dalexsoto