kernel connection list #3810
kernel connection list #3810
Conversation
jonsequitur
force-pushed
the
MRU-for-cell-kernel-chooser
branch
from
57a318a to
c524414
Compare
jonsequitur
force-pushed
the
MRU-for-cell-kernel-chooser
branch
2 times, most recently
from
d88eaa3 to
0e81279
Compare
jonsequitur
force-pushed
the
MRU-for-cell-kernel-chooser
branch
from
8662791 to
5b970f4
Compare
jonsequitur
requested review from
colombod,
shyamnamboodiripad and
AbhitejJohn
| @@ -24,7 +24,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <Compile Include="..\dotnet-interactive\Pocket\Format.CustomizeLogString.cs" Link="Pocket\Format.CustomizeLogString.cs" /> | |||
| <Compile Include="..\dotnet-interactive\(Pocket)\Logger\Format.CustomizeLogString.cs" Link="Pocket\Format.CustomizeLogString.cs" /> | |||
There was a problem hiding this comment.
Brackets in the path are interesting, did something prompt us to make that change?
There was a problem hiding this comment.
This colocates this PocketLogger customization file with the actual (virtual) location PocketLogger files in the solution explorer.
| _defaultTypeFormatters.PushRange(JsonFormatter.DefaultFormatters.Reverse().ToArray()); | ||
| _defaultTypeFormatters.PushRange(PlainTextSummaryFormatter.DefaultFormatters.Reverse().ToArray()); | ||
| _defaultTypeFormatters.PushRange(PlainTextFormatter.DefaultFormatters.Reverse().ToArray()); | ||
| // FIX: (ResetToDefault) remove cast. (This is working around a VS preview bug.) |
There was a problem hiding this comment.
Can we link to it by any chance?
There was a problem hiding this comment.
I don't have a bug number for it and am still looking for a stable repro.
| codeExpansion); | ||
| } | ||
|
|
||
| _checkedKernelSpecs = true; |
There was a problem hiding this comment.
For another iteration, we touched on this in our offline walkthrough of the PR, it would be nice to have a means of refreshing this cache based on a counter.
There was a problem hiding this comment.
Refreshing it in-process is less interesting than adding a cache's longer-lived than the process but that's for another day.
| ? { transientOutputs: true, transientDocumentMetadata: { custom: true }, transientCellMetadata: { custom: true } } | ||
| : {}; | ||
| // FIX: does this solve incorrect dirty state? | ||
| ? { |
There was a problem hiding this comment.
Weird, I'm not seeing any difference between these two conditions. Is this temporary?
There was a problem hiding this comment.
They're the same. This was an attempt to see if this code does anything at all or is implicated in a bug I'm investigating.
# Conflicts: # src/Microsoft.DotNet.Interactive.Tests/Connection/SerializationTests.Command_contract_has_not_been_broken.approved.SendEditableCode.json
jonsequitur
force-pushed
the
MRU-for-cell-kernel-chooser
branch
from
0139ea2 to
393ea23
Compare
This feature adds a menu for quick connections to subkernels. It will address the following issues: