Sync mirror changes into release/dev17.14 #18593
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### AI description (iteration 1) #### PR Classification This pull request is for a NuGet patch release, focusing on updating build configurations and dependencies. #### PR Summary This pull request updates build scripts and configuration files to support a new NuGet patch release, ensuring compatibility with updated Microsoft Build packages. - `/eng/build.sh`: Added no-operation implementations for `--runtimesourcefeed` and `--runtimesourcefeedkey` arguments. - `/eng/Versions.props`: Updated Microsoft Build package versions to use a unified `MicrosoftBuildVersion` variable. - `/eng/SourceBuildPrebuiltBaseline.xml`: Added new usages for Microsoft Build packages with version `17.13.26`. - `/azure-pipelines.yml`: Enabled internal sources for source build parameters. - `/NuGet.config`: Added a new package source for `msbuild-Trusted`. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
rel/d17.14 ---- #### AI description (iteration 1) #### PR Classification NuGet package update for a specific release branch. #### PR Summary This pull request updates the Azure Pipelines configuration to target the `rel/d17.14` branch for Visual Studio insertion. This change ensures that the build and release processes are aligned with the correct branch for the upcoming release. - Updated `azure-pipelines.yml` to set `VSInsertionTargetBranchName` to `rel/d17.14`. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
✅ No release notes required |
|
@dotnet/source-build can you approve please? |
Comment on lines
+31
to
+34
| <Usage Id="Microsoft.Build.Framework" Version="17.13.26" IsDirectDependency="true"/> | ||
| <Usage Id="Microsoft.Build.Tasks.Core" Version="17.13.26" IsDirectDependency="true"/> | ||
| <Usage Id="Microsoft.Build.Utilities.Core" Version="17.13.26" IsDirectDependency="true"/> | ||
| <Usage Id="Microsoft.NET.StringTools" Version="17.13.26"/> |
There was a problem hiding this comment.
This feels fishy to me. These msbuild dependencies should not be prebuilts because they should be coming from the msbuild intermediate. In other words, the msbuild dependencies are out of sync with the version of the msbuild intermediate defined in the Version.Details.xml file, which I believe is causing these prebuilts. Please use darc to update the msbuild dependencies to the version you're specifying here. That should update the intermediate to the appropriate version, which will in turn allow you to remove these prebuilt baseline entries from this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 7 commits synced from the mirror repository.